Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid payload reservation and copy when change is going to be rejected by history [13120] #2311

Merged
merged 16 commits into from
Dec 3, 2021
Merged

Avoid payload reservation and copy when change is going to be rejected by history [13120] #2311

merged 16 commits into from
Dec 3, 2021

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Nov 10, 2021 •
edited
Loading

This PR adds a mechanism on ReaderHistory to check if a new change will be accepted into it. This allows the code on processDataMsg to avoid copying the change information (and, possibly, its payload) for a sample that is going to be rejected

@MiguelCompany MiguelCompany added this to the v2.5.0 milestone Nov 10, 2021
@MiguelCompany MiguelCompany added no-aarch Skip build & test for aarch64 no-test Skip CI tests if PR marked with this label labels Nov 10, 2021
@MiguelCompany MiguelCompany force-pushed the feature/reader-history_can-be-added branch from b32666f to 935d603 Compare November 10, 2021 15:42
@MiguelCompany MiguelCompany force-pushed the feature/reader-history_can-be-added branch from 935d603 to 698e96c Compare November 22, 2021 12:02
@MiguelCompany MiguelCompany removed no-test Skip CI tests if PR marked with this label no-aarch Skip build & test for aarch64 labels Nov 22, 2021
@MiguelCompany MiguelCompany marked this pull request as ready for review November 22, 2021 14:06
@MiguelCompany
Copy link
Member Author

@richiprosima Please test this

@MiguelCompany MiguelCompany mentioned this pull request Nov 22, 2021
Merged
@MiguelCompany
Copy link
Member Author

@richiprosima Please test aarch64

@MiguelCompany MiguelCompany changed the title Avoid payload reservation and copy when change is going to be rejected by history Avoid payload reservation and copy when change is going to be rejected by history [13120] Dec 1, 2021
@MiguelCompany
Refs 12540. Added ReaderHistory::can_change_be_added declaration.
d833b8b 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12540. Added ReaderHistory::can_change_be_added implementation.
d48b2c8 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12540. Added SubscriberHistory::can_change_be_added implementation.
c4fc116 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12540. Using can_change_be_added on StatelessReader::processData…
209232f 
…Msg.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12540. Using can_change_be_added on StatefulReader::processDataMsg.
42aafb7 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12540. Avoid calling unknown_missing_changes_up_to twice.
b6d9405 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12540. Fix call on EDPSimple.
3d18f0e 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12540. Rename method with _nts.
15d8f16 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12540. Uncrustify.
64f5473 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13120. Make processDataMsg return false when can_change_be_added…
e17467f 
…_nts returns false.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13120. Always assert liveliness on scope exit.
761b391 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the feature/reader-history_can-be-added branch from 698e96c to 761b391 Compare December 2, 2021 10:21
@MiguelCompany
Refs 13120. Uncrustify.
a9399fd 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13120. Completely discard changes that will never be accepted.
d9f3e8d 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13120. Refactor method input.
2a7457c 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany merged commit 195dece into master Dec 3, 2021
@MiguelCompany MiguelCompany deleted the feature/reader-history_can-be-added branch December 3, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richiware richiware richiware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @richiware