Correctly build fuzz harness #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Maggi <federico@maggi.cc>
Signed-off-by: Federico Maggi <federico@maggi.cc>
MiguelCompany
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #2273, and #2283
There was a missing
add_subdirectory(fuzz)in the mainCMakeLists.txt.This prevented the fuzzers to be actually built and I could not understand why the local tests were passing while the remote ones (on google/oss-fuzz) were failing.
I had stale files into the
build/out/fast-ddsdirectory that made the tests always pass, while of course the production environment doesn't have those files cached.Hopefully final fix on this refactoring.