Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for partitions on DataWriterQoS and DataReaderQoS [12709] #2274

Merged
merged 5 commits into from
Oct 26, 2021

Conversation

jsan-rt
Copy link
Contributor

@jsan-rt jsan-rt commented Oct 18, 2021

Added support for partitions on DataReaders/DataWriters when using profile creation.

Documentation PR: eProsima/Fast-DDS-docs#294

…when using profiles

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt jsan-rt marked this pull request as draft October 19, 2021 09:51
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt jsan-rt marked this pull request as ready for review October 19, 2021 13:24
JLBuenoLopez
JLBuenoLopez previously approved these changes Oct 20, 2021
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany
Copy link
Member

We need to update the docs for this

@MiguelCompany MiguelCompany added the doc-pending Issue or PR which is pending to be documented label Oct 21, 2021
…rtyPolicyQos

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JLBuenoLopez JLBuenoLopez added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed doc-pending Issue or PR which is pending to be documented labels Oct 26, 2021
@MiguelCompany MiguelCompany merged commit c145a6f into master Oct 26, 2021
@MiguelCompany MiguelCompany deleted the feature/partition_on_endpoint branch October 26, 2021 07:40
@MiguelCompany
Copy link
Member

@Mergifyio backport 2.3.x

@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2021

backport 2.3.x

✅ Backports have been created

JLBuenoLopez pushed a commit that referenced this pull request Oct 27, 2021
* Refs #11849: Added support for partitions on DataWriters/DataReaders when using profiles

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #11849: Added Blackbox test and associated XML profiles

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #11849: Cleaned up Blackbox test includes

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #11849: Cleaned up partition string tokenizing

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #11849: Added test to check that partitions can be set via PropertyPolicyQos

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
(cherry picked from commit c145a6f)
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

# Conflicts:
#	test/blackbox/CMakeLists.txt
#	test/unittest/dds/subscriber/SubscriberTests.cpp
MiguelCompany pushed a commit that referenced this pull request Oct 28, 2021
* Support for partitions on DataWriterQoS and DataReaderQoS (#2274)

* Refs #11849: Added support for partitions on DataWriters/DataReaders when using profiles

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #11849: Added Blackbox test and associated XML profiles

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #11849: Cleaned up Blackbox test includes

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #11849: Cleaned up partition string tokenizing

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #11849: Added test to check that partitions can be set via PropertyPolicyQos

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
(cherry picked from commit c145a6f)
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

# Conflicts:
#	test/blackbox/CMakeLists.txt
#	test/unittest/dds/subscriber/SubscriberTests.cpp

* Refs #12709: fix backport conflicts

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Support for partitions on DataWriterQoS and DataReaderQoS [11849]
3 participants