-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for partitions on DataWriterQoS and DataReaderQoS [12709] #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when using profiles Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
JLBuenoLopez
previously approved these changes
Oct 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We need to update the docs for this |
MiguelCompany
added
the
doc-pending
Issue or PR which is pending to be documented
label
Oct 21, 2021
…rtyPolicyQos Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
JLBuenoLopez
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JLBuenoLopez
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
doc-pending
Issue or PR which is pending to be documented
labels
Oct 26, 2021
@Mergifyio backport 2.3.x |
✅ Backports have been created
|
JLBuenoLopez
pushed a commit
that referenced
this pull request
Oct 27, 2021
* Refs #11849: Added support for partitions on DataWriters/DataReaders when using profiles Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #11849: Added Blackbox test and associated XML profiles Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #11849: Cleaned up Blackbox test includes Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #11849: Cleaned up partition string tokenizing Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #11849: Added test to check that partitions can be set via PropertyPolicyQos Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> (cherry picked from commit c145a6f) Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> # Conflicts: # test/blackbox/CMakeLists.txt # test/unittest/dds/subscriber/SubscriberTests.cpp
MiguelCompany
pushed a commit
that referenced
this pull request
Oct 28, 2021
* Support for partitions on DataWriterQoS and DataReaderQoS (#2274) * Refs #11849: Added support for partitions on DataWriters/DataReaders when using profiles Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #11849: Added Blackbox test and associated XML profiles Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #11849: Cleaned up Blackbox test includes Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #11849: Cleaned up partition string tokenizing Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #11849: Added test to check that partitions can be set via PropertyPolicyQos Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> (cherry picked from commit c145a6f) Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> # Conflicts: # test/blackbox/CMakeLists.txt # test/unittest/dds/subscriber/SubscriberTests.cpp * Refs #12709: fix backport conflicts Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for partitions on DataReaders/DataWriters when using profile creation.
Documentation PR: eProsima/Fast-DDS-docs#294