Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported some function on Windows [12673] #2261

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

richiware
Copy link
Member

When generate source code with TypeObjects, on Windows the user application doesn't compile because some needed functions are not exported. This PR fixes this.

Signed-off-by: Ricardo González <ricardo@richiware.dev>
@richiware richiware changed the title Exported some function on Windows Exported some function on Windows [12673] Oct 13, 2021
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please uncrustify. Other than that it looks good to me.

Signed-off-by: Ricardo González <ricardo@richiware.dev>
@richiware richiware force-pushed the bugfix/annotations-export-functions branch from 3e7e321 to f8e33a8 Compare October 13, 2021 09:58
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany added this to the v2.5.0 milestone Oct 29, 2021
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany MiguelCompany merged commit 71d986f into master Dec 10, 2021
@MiguelCompany MiguelCompany deleted the bugfix/annotations-export-functions branch December 10, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants