Periodic heartbeat also depending on ReaderProxy's low_mark [12642] #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo González <ricardo@richiware.dev>
|
What should happen if the writer's history is empty but the low mark of the reader proxy is below |
Technically the HEARTBEAT won't be sent. Practically (using DDS-API) the history never will be empty until the samples are acknowledge. |
There's the case when you create a DataWriter, and then remove it. In that case, the EDP publications writer will have an empty history, but the min seq will be 2 instead of 1. |
MiguelCompany
requested changes
Oct 14, 2021
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
|
@richiprosima Please test discovery-server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using new flow controllers for low bandwidth communications I've realized periodic HEARTBEATS stop begin sent. This is caused my history's depth is low, and when the periodic heartbeat is triggered, all samples in the
ReaderProxyare in UNSENT state.This PR adds periodic HEARTBEAT also dependes in the low_mark. I f the low_mark is less than the minimun sequence number in the history, the HEARTBEAT is sent.