Adds profile loading from XML string [12821] #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfdc90e to
5f98fce
Compare
JLBuenoLopez
suggested changes
Oct 20, 2021
There was a problem hiding this comment.
Uncrustify is still complaining about the code style for some files: http://jenkins.eprosima.com:8080/job/fastdds_github_uncrustify/3115/
Also, would you mind adding some test for this new feature?
Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
dd7cdb7 to
10b0358
Compare
Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
…ading from file Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
|
@JLBuenoLopez-eProsima Hi, thanks for the feedback. I've added a test that loads the same profiles-file used in other test but as a string. |
JLBuenoLopez
approved these changes
Nov 3, 2021
There was a problem hiding this comment.
LGTM
Thanks a lot for the tests, @SamuelWHalodi. We should also include this new feature in our documentation before merging. Also, as this PR is adding new API, I have added it to the 2.5.0 milestone which is going to be released next month (December 2021).
|
Thanks again @SamuelWHalodi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2179
Signed-off-by: Samuel Wilhelmsson samuel@halodi.com
This is a remake of a previous PR had to be closed because of a bad merge.
Related documentation PR: eProsima/Fast-DDS-docs#303