Fix buffers exhaution when compiled with statistics [12629] #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
jparisu
suggested changes
Oct 7, 2021
There was a problem hiding this comment.
in file src/fastdds/test/mock/rtps/RTPSMessageGroup/fastdds/rtps/messages/RTPSMessageGroup.h update the constructors so they allow the arguments with default values. It fails the compilation with certain CMake args otherwise:
"-DCMAKE_BUILD_TYPE=Debug",
"-DEPROSIMA_BUILD=OFF",
"-DCOMPILE_EXAMPLES=ON",
"-DFASTDDS_STATISTICS=OFF",
"-DSHM_TRANSPORT_DEFAULT=OFF",
"-DEPROSIMA_BUILD_TESTS=ON",
"-DGTEST_INDIVIDUAL=OFF",
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
|
Unrelated failures. Going in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 14d3323 broke init_monitor_tests from Fast-DDS-statistics-backend.
The reason is that, when compiled with statistics, a new async flow controller is created but the same number of buffers are preallocated, leading to a resource exhaution and falling into a hangup state.