Fix incosistences between Pub/Sub history and RTPS history [12620] #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo González <ricardo@richiware.dev>
Signed-off-by: Ricardo González <ricardo@richiware.dev>
Signed-off-by: Ricardo González <ricardo@richiware.dev>
b6f7a48 to
a622869
Compare
Signed-off-by: Ricardo González <ricardo@richiware.dev>
909ad48 to
40f56a0
Compare
IkerLuengo
suggested changes
Oct 11, 2021
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@IkerLuengo I fixed this on e87d31a |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
approved these changes
Oct 27, 2021
|
@Mergifyio backport 2.3.x |
mergify bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
* Refs #12161. Add test large fragmented samples with key Signed-off-by: Ricardo González <ricardo@richiware.dev> * Refs #12161. Fix deserializing not completed sample Signed-off-by: Ricardo González <ricardo@richiware.dev> * Refs #12161. Fix inconsistence between histories Signed-off-by: Ricardo González <ricardo@richiware.dev> * Refs #12161. Fix uncrustify Signed-off-by: Ricardo González <ricardo@richiware.dev> * Refs 12620. Added override on overriden method. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Added new virtual method to ReaderHistory mock Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12620. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 6003592) # Conflicts: # test/blackbox/CMakeLists.txt # test/blackbox/common/BlackboxTestsPubSubFragments.cpp
✅ Backports have been created
|
|
👏🏾 Thanks @MiguelCompany |
MiguelCompany
pushed a commit
that referenced
this pull request
Mar 18, 2022
* Fix incosistences between Pub/Sub history and RTPS history (#2239) * Refs #12161. Add test large fragmented samples with key Signed-off-by: Ricardo González <ricardo@richiware.dev> * Refs #12161. Fix deserializing not completed sample Signed-off-by: Ricardo González <ricardo@richiware.dev> * Refs #12161. Fix inconsistence between histories Signed-off-by: Ricardo González <ricardo@richiware.dev> * Refs #12161. Fix uncrustify Signed-off-by: Ricardo González <ricardo@richiware.dev> * Refs 12620. Added override on overriden method. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Added new virtual method to ReaderHistory mock Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12620. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 6003592) # Conflicts: # test/blackbox/CMakeLists.txt # test/blackbox/common/BlackboxTestsPubSubFragments.cpp * Refs #12620. Fix conflict Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González <ricardo@richiware.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it is received a HEARTBEAT, its firstSN is used to find fragmented samples not fully assembled yet and remove them. This functionality is done by
ReaderHistory::remove_fragmented_changes_until. But this function only removes the changes from theReaderHistory, but not fromSubscriberHistory, provoking inconsistences in the instances' vector.