-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid bad_node_size exception when cross building [12583] #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
changed the title
Avoid bad_node_size exception when cross building
Avoid bad_node_size exception when cross building [12583]
Sep 24, 2021
This will permanently fix foonathan/memory#103, foonathan/memory#123. |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@Mergifyio backport 2.3.x 2.2.x 2.1.x |
Command
|
IkerLuengo
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mergify bot
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Refs 12581. Avoid bad_node_size exception Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12583. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 1484609)
mergify bot
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Refs 12581. Avoid bad_node_size exception Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12583. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 1484609)
mergify bot
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Refs 12581. Avoid bad_node_size exception Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12583. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 1484609)
Command
|
pablorcum
pushed a commit
to pablorcum/Fast-DDS
that referenced
this pull request
Sep 27, 2021
* Refs 12581. Avoid bad_node_size exception Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12583. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When foonathan/memory is cross-compiled, and the
node_size_dbg
tool cannot be executed with an emulator, some custom node types are used to calculate the size of the nodes being requested to the allocator.After some reports of a
bad_node_size
exception being thrown, I investigated this deeply, and found the custom type was not compliant with certain std implementations (libstdc++).