Support of disable_heartbeat_piggyback through XML and DDS API [12533] #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IkerLuengo
suggested changes
Oct 14, 2021
|
@richiware This has conflicts, please rebase |
b33e032 to
349efca
Compare
|
@MiguelCompany I've rebased and added a new blackbox test. |
JLBuenoLopez
previously approved these changes
Dec 15, 2021
Comment on lines
84
to
85
| std::list<KeyedHelloWorld> uniquekey_keyedhelloworld_data_generator( | ||
| size_t max) | ||
| { | ||
| uint16_t index = 0; | ||
| size_t maximum = max ? max : 10; | ||
| std::list<KeyedHelloWorld> returnedValue(maximum); | ||
|
|
||
| std::generate(returnedValue.begin(), returnedValue.end(), [&index] | ||
| { | ||
| KeyedHelloWorld hello; | ||
| hello.index(index); | ||
| hello.key(index + 1); | ||
| std::stringstream ss; | ||
| ss << "HelloWorld " << index; | ||
| hello.message(ss.str()); | ||
| ++index; | ||
| return hello; | ||
| }); | ||
|
|
||
| return returnedValue; | ||
| } |
There was a problem hiding this comment.
Maybe, instead of creating the new generator where the only change with respect to the already existing generator is use a different key in each sample, the previous generator can be used giving as parameter flag in case that the key must be unique.
std::list<KeyedHelloWorld> default_keyedhelloworld_data_generator(
size_t max,
bool unique_key)
This is a mere suggestion and I am fine leaving the code as it is.
JLBuenoLopez
previously approved these changes
Dec 16, 2021
|
@richiprosima Please test Windows |
|
@richiprosima please test Windows |
Signed-off-by: Ricardo González <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
…d API. Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
774d199 to
aefa0de
Compare
|
@richiprosima please test this |
|
@richiprosima Please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.