Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: add DomainParticipantQos::flow_controllers doxygen documentation #2209

Merged

Conversation

JLBuenoLopez
Copy link
Contributor

Signed-off-by: JLBuenoLopez-eProsima joseluisbueno@eprosima.com

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
@JLBuenoLopez JLBuenoLopez added the skip-ci Automatically pass CI label Sep 17, 2021
MiguelCompany
MiguelCompany previously approved these changes Sep 17, 2021
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also document FlowControllerDescriptorList at the beginning of the class

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 5d7cee3 into master Sep 17, 2021
@MiguelCompany MiguelCompany deleted the hotfix/add-domainparticipantqos-flowcontroller-doxydoc branch September 17, 2021 07:53
SamuelWHalodi pushed a commit to SamuelWHalodi/Fast-DDS that referenced this pull request Oct 4, 2021
…Prosima#2209)

* Hotfix: add DomainParticipantQos::flow_controllers doxygen documentation

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>

* Apply review suggestion

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants