Changes to facilitate bindings to python #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although these lines are legal, these 'using' structures get a parsing error in SWIG. And since the operators are already inherited from the base class, they are redundant, and can be removed to simplify our lives in the binding process Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
This facilitates the binding to Python Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
fc93151 to
989b999
Compare
MiguelCompany
requested changes
Sep 14, 2021
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
MiguelCompany
requested changes
Sep 14, 2021
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
MiguelCompany
requested changes
Sep 15, 2021
Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
|
@richiprosima Please test mac |
|
@richiprosima Please test this |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
|
All failures unrelated. |
SamuelWHalodi
pushed a commit
to SamuelWHalodi/Fast-DDS
that referenced
this pull request
Oct 4, 2021
* Operators are inherited Although these lines are legal, these 'using' structures get a parsing error in SWIG. And since the operators are already inherited from the base class, they are redundant, and can be removed to simplify our lives in the binding process Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Define operators inside the classes This facilitates the binding to Python Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Requested changes Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Requested changes Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * More requested changes Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Reverting changes on rtps/common headers. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.