Refactor DataReaderImpl to use a new DataReaderHistory class [12404] #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
df8f6d0 to
7951478
Compare
MiguelCompany
added a commit
that referenced
this pull request
Oct 22, 2021
* Refs 12400. Duplicating SubscriberHistory into DataReaderHistory. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Using DataReaderHistory on DataReaderImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Avoid using TopicAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Additional cleanup. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Using DDS SampleInfo. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12404. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Dec 7, 2021
* Refs 12400. Duplicating SubscriberHistory into DataReaderHistory. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Using DataReaderHistory on DataReaderImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Avoid using TopicAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Additional cleanup. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Using DDS SampleInfo. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12404. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Dec 13, 2021
* Refs 12400. Duplicating SubscriberHistory into DataReaderHistory. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Using DataReaderHistory on DataReaderImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Avoid using TopicAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Additional cleanup. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Using DDS SampleInfo. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12404. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Dec 17, 2021
* Refs 12400. Duplicating SubscriberHistory into DataReaderHistory. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Using DataReaderHistory on DataReaderImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Avoid using TopicAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Additional cleanup. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Using DDS SampleInfo. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12404. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Dec 20, 2021
* Refs 12400. Duplicating SubscriberHistory into DataReaderHistory. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Using DataReaderHistory on DataReaderImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Avoid using TopicAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Additional cleanup. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Using DDS SampleInfo. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12404. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Dec 21, 2021
* Refactor DataReaderImpl to use a new DataReaderHistory class (#2177) * Refs 12400. Duplicating SubscriberHistory into DataReaderHistory. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Using DataReaderHistory on DataReaderImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Avoid using TopicAttributes. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Additional cleanup. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Using DDS SampleInfo. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12404. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Fixed DataReaderHistory (#2194) * DataReader test for sample_info fields (#2193) * Refs 12400. Initial test infrastructure. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Additional tests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Tests are run twice with a take in the middle. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12469. Fixed warnings. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12469. Additional comments. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Adding implementation for instance_state and view_state (#2298) * Refs 12400. Added DataReaderCacheChange. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Added DataReaderInstance. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. DataReaderHistory using new types. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Removing unnecessary method from SubscriberHistory. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. ReadTakeCommand receives full instance information. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. ReadTakeCommand checks for instance states. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. ReadTakeCommand fills sample info from instance data. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Added insert method to ResourceLimitedVector. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. DataReaderInstance uses ResourceLimitedVector. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. get_first_untaken_info takes sample info from instance data. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Discard received change when older than oldest. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Fixing KEEP_ALL with keys. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Refactor to always use instances. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Basic structure for update instance state. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Adding alive_writers and current_owner to DataReaderInstance. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Implementing writer_alive. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Implementing writer_dispose. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Implementing writer_unregister. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Setting NOT_NEW on returned instances. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Correct return code when returning samples with no data. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Set view_state to NEW when changing instance_state to ALIVE. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Moving generation counts into CacheChange_t. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Assigning generation counts after processing instance state. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Update instance_state when writer becomes not alive. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Clear alive_writers when changing generation. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Add writer_unmatched to ReaderHistory. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. NOT_ALIVE_UNREGISTERED should not return valid data. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Set autodispose_unregistered_instances to false on test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Remove instance when it becomes empty and is not alive. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Refactor into writer_not_alive. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Keeping samples from unmatched writers. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Avoid keeping non-notified samples. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Fixing compilation warnings on windows. Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 12758. Fixing assertion on WriterProxy logic. If we only notify fragmented DATA reception on completion we should only notify removal of fully assembled samples. Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 12758 Fixing DataReaderHistory test that checks DataWriter disposal behaviour. Signed-off-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 12758. Use move semantics. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Use ResourceLimitedVector for writers. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Apply pre-allocation policies. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. PubSubReader. Account for writer_guid on last_seq checks. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Added can_change_be_added_nts. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Removed unused method. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Always use completed changes for key computation. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Fixed ResourceLimitedVector::insert. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Uncrustify. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Avoid dynamic allocation inside remove_changes_with_pred. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Optimization on DataReaderHistory::remove_change_nts. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Method writer_unmatched documented and improved. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Do not complete changes for non-keyed topics. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Do not remove incomplete changes for keyed topics. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Different removal policy on ReaderHistory and DataReaderHistory. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Fix unused parameter warning. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Removed unused header. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Doxydoc improvements. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12758. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Barro <miguelbarro@eprosima.com> * Refs 12400. Adding checks for insert on ResourceLimitedVectorTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Fixed rvalue version of ResourceLimitedVector::insert. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Added feature to versions.md. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Fixed inclusion of DataReaderHistory.cpp on CMake files. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 12400. Add missing feature to versions.md. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Barro <miguelbarro@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.