Fix ABBA deadlock in flow controller core [12394] #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González <ricardo@richiware.dev>
MiguelCompany
requested changes
Sep 13, 2021
test/mock/rtps/ReaderLocator/fastdds/rtps/writer/ReaderLocator.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
SamuelWHalodi
pushed a commit
to SamuelWHalodi/Fast-DDS
that referenced
this pull request
Oct 4, 2021
* Refs #12393. Fix deadlock in flow controller core Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #12394. Fix compilation on tests Signed-off-by: Ricardo González <ricardo@richiware.dev> * Apply suggestion Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTPSMessageGroupused by the flow controller could lead in a ABBA deadlock when the sender is changed. This PR fixes this. Instead of use the writer's mutex, the LocatorSelectorSender has its own mutex.