Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing TLS Exceptions and Example #2173

Merged
merged 3 commits into from
Sep 17, 2021
Merged

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Aug 30, 2021

The actual certificates does not work in HelloWorldExampleTCP using TLS.
ca.pem has been regenerated and used in Publisher side to check the certificate of the subscriber.

Signed-off-by: jparisu javierparis@eprosima.com

Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu marked this pull request as draft September 1, 2021 06:09
jparisu added 2 commits September 2, 2021 11:19
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu marked this pull request as ready for review September 2, 2021 09:46
@jparisu jparisu changed the title Fixing HelloWorldExampleTCP certificates Fixing TLS calls and HelloWorldExampleTCP certificates Sep 2, 2021
@jparisu jparisu changed the title Fixing TLS calls and HelloWorldExampleTCP certificates Fixing TLS Exceptions and Example Sep 6, 2021
@EduPonz EduPonz added this to the v2.4.0 milestone Sep 9, 2021
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit ec84c0b into master Sep 17, 2021
@MiguelCompany MiguelCompany deleted the feature/tcp-tls-example branch September 17, 2021 09:52
SamuelWHalodi pushed a commit to SamuelWHalodi/Fast-DDS that referenced this pull request Oct 4, 2021
* Fixing HelloWorldExampleTCP certificates

Signed-off-by: jparisu <javierparis@eprosima.com>

* regenerate certificates

Signed-off-by: jparisu <javierparis@eprosima.com>

* Add try catch to probable fails in asio calls

Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants