Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix statistics writers sometimes uses the user's publisher [12391] #2172

Merged
merged 6 commits into from
Nov 22, 2021

Conversation

richiware
Copy link
Member

This can lead to an error. If the user's publisher is configured with a partition, there will no matching with statistics_backend

@richiware richiware changed the title Fix statistics writers sometimes uses the user's publisher Fix statistics writers sometimes uses the user's publisher [12391] Aug 30, 2021
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, but we need a regression test for this.

@EduPonz EduPonz added this to the v2.4.0 milestone Sep 9, 2021
@MiguelCompany MiguelCompany modified the milestones: v2.4.0, v2.4.1 Sep 17, 2021
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
richiware and others added 2 commits October 11, 2021 09:59
Signed-off-by: Ricardo González <ricardo@richiware.dev>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Copy link
Member Author

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MiguelCompany
MiguelCompany previously approved these changes Nov 17, 2021
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany
Copy link
Member

Running Linux job with DDSStatistics tests enabled:

Build Status

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany merged commit 35910ca into master Nov 22, 2021
@MiguelCompany MiguelCompany deleted the featuree/12390 branch November 22, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants