Allow DomainParticipantQos updates for UserDataQosPolicy and adding new servers to the remote server list #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refs 12196: add empty api Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
) * Refs #12196: link dds and rtps layers Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: modify and announce change in user data QoS Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: update remote servers list Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: add update_attributes method to RTPSParticipant mock class Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: protect remote servers list with PDP mutex Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: fix ParticipantTests.CheckDomainParticipantQos test. The first time the QoS was set it was calling to the update_attributes method Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs 12196: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: uncrustify Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: reset hasChanged flag Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: refactor to check if Qos has changed both in DDS and RTPS layers Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: fix ParticipantTests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: bug fix Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
* Refs 12197: Check that the only modification in wire_protocol is the list of servers Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12196: Unit test for changing WireProtocolQosPolicy Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12196: Apply suggestions Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12196: Uncrustify Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
* Refs #12196: modify Blackbox PubSubParticipant API to include UserDataQosPolicy Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: add discovery participant API to PubSubParticipant Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: add blackbox test that checks user data QoS update Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: uncrustify Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: fix deadlock in Blackbox test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
* Refs 12278: Only add new servers Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Update Discovery Server with new servers Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Check that old server list is a subset of the new one when using DDS layer Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Test now checks that servers cannot be removed from list Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Manually match new server' PDP endpoints Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Discovery test for adding servers Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Randomize test parameters Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Uncrustify Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Address Windows warning Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Apply suggestions Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Use nullptr and add headers Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Add SystemInfo source to CMake Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
|
@richiprosima please test mac |
|
@richiprosima please test windows |
EduPonz
approved these changes
Aug 12, 2021
SamuelWHalodi
pushed a commit
to SamuelWHalodi/Fast-DDS
that referenced
this pull request
Oct 4, 2021
…ew servers to the remote server list (eProsima#2142) * Add empty api (eProsima#2111) * Refs 12196: add empty api Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * DomainParticipantQos propagation to the RTPS layer implementation (eProsima#2113) * Refs #12196: link dds and rtps layers Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: modify and announce change in user data QoS Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: update remote servers list Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: add update_attributes method to RTPSParticipant mock class Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: protect remote servers list with PDP mutex Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: fix ParticipantTests.CheckDomainParticipantQos test. The first time the QoS was set it was calling to the update_attributes method Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs 12196: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: uncrustify Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: reset hasChanged flag Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: refactor to check if Qos has changed both in DDS and RTPS layers Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: fix ParticipantTests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: bug fix Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * WireProtocolConfigQos update through DomainParticipant::set_qos (eProsima#2131) * Refs 12197: Check that the only modification in wire_protocol is the list of servers Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12196: Unit test for changing WireProtocolQosPolicy Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12196: Apply suggestions Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12196: Uncrustify Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Add UserDataQoS blackbox test (eProsima#2130) * Refs #12196: modify Blackbox PubSubParticipant API to include UserDataQosPolicy Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: add discovery participant API to PubSubParticipant Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: add blackbox test that checks user data QoS update Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: uncrustify Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: fix deadlock in Blackbox test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #12196: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Propagate servers list updates to PDPServer and PDPClient (eProsima#2138) * Refs 12278: Only add new servers Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Update Discovery Server with new servers Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Check that old server list is a subset of the new one when using DDS layer Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Test now checks that servers cannot be removed from list Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Manually match new server' PDP endpoints Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Discovery test for adding servers Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Randomize test parameters Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Uncrustify Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Address Windows warning Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Apply suggestions Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Use nullptr and add headers Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12278: Add SystemInfo source to CMake Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
user_data.