Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DDS example: Basic Configuration HelloWorld [12329] #2122

Merged
merged 31 commits into from
Dec 21, 2021

Conversation

juanlofer-eprosima
Copy link
Contributor

Signed-off-by: juanlofer-eprosima juanlopez@eprosima.com

@juanlofer-eprosima juanlofer-eprosima force-pushed the feature/helloworld-refactor branch from 465ff70 to b4c6b6f Compare August 9, 2021 06:43
@juanlofer-eprosima juanlofer-eprosima marked this pull request as ready for review September 1, 2021 13:01
examples/C++/DDS/HelloWorldExample/HelloWorldSubscriber.h Outdated Show resolved Hide resolved
examples/C++/DDS/HelloWorldExample/HelloWorldSubscriber.h Outdated Show resolved Hide resolved
examples/C++/DDS/HelloWorldExample/HelloWorldPublisher.h Outdated Show resolved Hide resolved
examples/C++/DDS/HelloWorldExample/HelloWorldPublisher.h Outdated Show resolved Hide resolved
examples/C++/DDS/HelloWorldExample/HelloWorld_main.cpp Outdated Show resolved Hide resolved
examples/C++/DDS/HelloWorldExample/HelloWorldPublisher.cpp Outdated Show resolved Hide resolved
examples/C++/DDS/HelloWorldExample/HelloWorldPublisher.cpp Outdated Show resolved Hide resolved
examples/C++/DDS/HelloWorldExample/HelloWorldPublisher.cpp Outdated Show resolved Hide resolved
@jparisu
Copy link
Contributor

jparisu commented Sep 2, 2021

We have decided to change this Example to a new BasicConfigurationExample instead of overwrite the current HelloWorldExample.

@jparisu
Copy link
Contributor

jparisu commented Sep 2, 2021

Extra configurations by arguments could be added in the future (maybe future PRs) :

  • allow more than publisher|subscriber as input (i.e. p|pub|writer|talker etc.)
  • change type name (useful for ROS2)
  • ROS2 mangling
  • allow partitions
  • create multiple publishers and/or subscribers in the same process (useful to check Intraprocess)
  • Add TCP to available transports
  • Active statistics

juanlofer-eprosima added a commit that referenced this pull request Sep 10, 2021
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
juanlofer-eprosima added a commit that referenced this pull request Sep 13, 2021
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
…onfiguration options increased

Signed-off-by: juanlofer-eprosima <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
@juanlofer-eprosima juanlofer-eprosima force-pushed the feature/helloworld-refactor branch from 693afea to 1dcbd03 Compare September 14, 2021 07:25
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
juanlofer-eprosima added a commit that referenced this pull request Sep 14, 2021
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
@juanlofer-eprosima juanlofer-eprosima changed the title HelloWorld refactor [12329] New DDS example: Basic Configuration HelloWorld [12329] Sep 14, 2021
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Copy link
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general

  • Please, change the name of the files so they fit with the name of the directory and the example (there are already too much HelloWorldPublisher.cpp files in the repository)
  • Add comments to each class and method in the header files so the example is easy to read and reproduce

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
juanlofer-eprosima added a commit that referenced this pull request Sep 20, 2021
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
juanlofer-eprosima added a commit that referenced this pull request Sep 20, 2021
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
@JLBuenoLopez JLBuenoLopez added this to the v2.5.0 milestone Dec 16, 2021
@JLBuenoLopez JLBuenoLopez added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Dec 16, 2021
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like this example to support data-sharing. You'd need to update the type and re-generate the type support. I'd also add a flag to disable it

examples/C++/DDS/BasicConfigurationExample/README.md Outdated Show resolved Hide resolved
examples/C++/DDS/BasicConfigurationExample/HelloWorld.idl Outdated Show resolved Hide resolved
@EduPonz EduPonz removed the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Dec 16, 2021
Signed-off-by: jparisu <javierparis@eprosima.com>
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed off-line, setting a transport should disable data-sharing, else, it should use whatever Fast DDS sees fit (in the same machine will be data-sharing, as the type is not dsh compatible). We'd need to update the readme as well

Signed-off-by: jparisu <javierparis@eprosima.com>
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update readme

jparisu added 2 commits December 20, 2021 16:10
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu added 2 commits December 21, 2021 08:07
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@EduPonz EduPonz added the skip-ci Automatically pass CI label Dec 21, 2021
Signed-off-by: jparisu <javierparis@eprosima.com>
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit ec99402 into master Dec 21, 2021
@EduPonz EduPonz deleted the feature/helloworld-refactor branch December 21, 2021 13:34
juanlofer-eprosima added a commit that referenced this pull request Jun 20, 2022
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
juanlofer-eprosima added a commit that referenced this pull request Jun 20, 2022
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
juanlofer-eprosima added a commit that referenced this pull request Jun 20, 2022
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
juanlofer-eprosima added a commit that referenced this pull request Jun 20, 2022
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
juanlofer-eprosima added a commit that referenced this pull request Sep 28, 2022
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
juanlofer-eprosima added a commit that referenced this pull request Sep 28, 2022
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
juanlofer-eprosima added a commit that referenced this pull request Sep 28, 2022
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
juanlofer-eprosima added a commit that referenced this pull request Sep 28, 2022
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-aarch Skip build & test for aarch64 no-test Skip CI tests if PR marked with this label skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants