-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New DDS example: Basic Configuration HelloWorld [12329] #2122
Conversation
465ff70
to
b4c6b6f
Compare
We have decided to change this Example to a new |
Extra configurations by arguments could be added in the future (maybe future PRs) :
|
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
…onfiguration options increased Signed-off-by: juanlofer-eprosima <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
693afea
to
1dcbd03
Compare
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general
- Please, change the name of the files so they fit with the name of the directory and the example (there are already too much HelloWorldPublisher.cpp files in the repository)
- Add comments to each class and method in the header files so the example is easy to read and reproduce
examples/C++/DDS/BasicConfigurationExample/HelloWorldSubscriber.cpp
Outdated
Show resolved
Hide resolved
examples/C++/DDS/BasicConfigurationExample/HelloWorldSubscriber.cpp
Outdated
Show resolved
Hide resolved
examples/C++/DDS/BasicConfigurationExample/HelloWorldPublisher.cpp
Outdated
Show resolved
Hide resolved
examples/C++/DDS/BasicConfigurationExample/HelloWorldPublisher.cpp
Outdated
Show resolved
Hide resolved
examples/C++/DDS/BasicConfigurationExample/HelloWorldPublisher.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like this example to support data-sharing. You'd need to update the type and re-generate the type support. I'd also add a flag to disable it
Signed-off-by: jparisu <javierparis@eprosima.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed off-line, setting a transport should disable data-sharing, else, it should use whatever Fast DDS sees fit (in the same machine will be data-sharing, as the type is not dsh compatible). We'd need to update the readme as well
Signed-off-by: jparisu <javierparis@eprosima.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update readme
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: juanlofer-eprosima juanlopez@eprosima.com