Deadline error when no Reliable DataReaders in VOLATILE DataWriters [12321] #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
|
@richiprosima Please test this |
MiguelCompany
requested changes
Aug 5, 2021
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
|
@Mergifyio backport master 2.2.x 2.1.x 2.0.x |
|
Command
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 5, 2021
…2112) * Refs #12321: Change handle reference Signed-off-by: jparisu <javierparis@eprosima.com> * Refs #12321: Add regression tests Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs #12321: Make test more robust Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12321: Apply suggestions Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> (cherry picked from commit e357fe8)
mergify bot
pushed a commit
that referenced
this pull request
Aug 5, 2021
…2112) * Refs #12321: Change handle reference Signed-off-by: jparisu <javierparis@eprosima.com> * Refs #12321: Add regression tests Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs #12321: Make test more robust Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12321: Apply suggestions Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> (cherry picked from commit e357fe8)
mergify bot
pushed a commit
that referenced
this pull request
Aug 5, 2021
…2112) * Refs #12321: Change handle reference Signed-off-by: jparisu <javierparis@eprosima.com> * Refs #12321: Add regression tests Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs #12321: Make test more robust Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12321: Apply suggestions Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> (cherry picked from commit e357fe8) # Conflicts: # src/cpp/fastdds/publisher/DataWriterImpl.cpp
mergify bot
pushed a commit
that referenced
this pull request
Aug 5, 2021
…2112) * Refs #12321: Change handle reference Signed-off-by: jparisu <javierparis@eprosima.com> * Refs #12321: Add regression tests Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs #12321: Make test more robust Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12321: Apply suggestions Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> (cherry picked from commit e357fe8) # Conflicts: # src/cpp/fastdds/publisher/DataWriterImpl.cpp
|
Command
|
MiguelCompany
added a commit
that referenced
this pull request
Aug 5, 2021
…2121) * Deadline error when no Reliable DataReaders in VOLATILE DataWriters (#2112) * Refs #12321: Change handle reference Signed-off-by: jparisu <javierparis@eprosima.com> * Refs #12321: Add regression tests Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs #12321: Make test more robust Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12321: Apply suggestions Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> (cherry picked from commit e357fe8) # Conflicts: # src/cpp/fastdds/publisher/DataWriterImpl.cpp * Fix conflicts Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: jparisu <69341543+jparisu@users.noreply.github.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Aug 5, 2021
…2120) * Deadline error when no Reliable DataReaders in VOLATILE DataWriters (#2112) * Refs #12321: Change handle reference Signed-off-by: jparisu <javierparis@eprosima.com> * Refs #12321: Add regression tests Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs #12321: Make test more robust Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Refs 12321: Apply suggestions Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> (cherry picked from commit e357fe8) # Conflicts: # src/cpp/fastdds/publisher/DataWriterImpl.cpp * Fix conflicts Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: jparisu <69341543+jparisu@users.noreply.github.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jparisu javierparis@eprosima.com