Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of DataWriter::get_type() [12286] #2101

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jul 29, 2021

Signed-off-by: Eduardo Ponz Segrelles eduardoponz@eprosima.com

Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
@EduPonz EduPonz requested a review from MiguelCompany July 29, 2021 06:16
@EduPonz EduPonz changed the title Implementation of DataWriter::get_type() Implementation of DataWriter::get_type() [12286] Jul 29, 2021
@EduPonz EduPonz added this to the v2.4.0 milestone Jul 29, 2021
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit 0531ed4 into master Aug 9, 2021
@EduPonz EduPonz deleted the bugfix/datawriter_get_type branch August 9, 2021 05:15
SamuelWHalodi pushed a commit to SamuelWHalodi/Fast-DDS that referenced this pull request Oct 4, 2021
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataWriter::get_type() missing an impl - but impl present in DataWriterImpl.hpp [12283]
2 participants