Avoid a volatile datasharing reader blocks a writer [12222] #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
requested changes
Jul 23, 2021
|
@richiprosima Please test this |
1b99cc5 to
f761f82
Compare
|
@MiguelCompany Fixed compilation error |
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
f761f82 to
a6476eb
Compare
MiguelCompany
approved these changes
Sep 6, 2021
|
Failed tests not related |
|
@Mergifyio backport 2.3.x |
mergify bot
pushed a commit
that referenced
this pull request
Sep 6, 2021
* Refs #11743. Add regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Volatire reader know acks samples in the writer pool Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Apply suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Fix error Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Fix compilation error with new flow controllers Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Fix segmentation fault Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit c97053e)
|
Command
|
MiguelCompany
added a commit
that referenced
this pull request
Sep 27, 2021
* Avoid a volatile datasharing reader blocks a writer [12222] (#2090) * Refs #11743. Add regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Volatire reader know acks samples in the writer pool Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Apply suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Fix error Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Fix compilation error with new flow controllers Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Fix segmentation fault Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit c97053e) * Fixed build error Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Fixed build error Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Ricardo González <ricardo@richiware.dev> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
SamuelWHalodi
pushed a commit
to SamuelWHalodi/Fast-DDS
that referenced
this pull request
Oct 4, 2021
…#2090) * Refs #11743. Add regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Volatire reader know acks samples in the writer pool Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Apply suggestions from code review Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Fix error Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Fix compilation error with new flow controllers Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #11743. Fix segmentation fault Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.