Check for NDEBUG in logInfo [12218] #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
|
@richiware please test this |
|
@richiprosima please test this |
SamuelWHalodi
pushed a commit
to SamuelWHalodi/Fast-DDS
that referenced
this pull request
Oct 4, 2021
Signed-off-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Signed-off-by: Samuel Wilhelmsson <samuel@halodi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is right now,
logInfoonly produces messages under the following conditions:HAVE_LOG_NO_INFOis false ANDFASTDDS_ENFORCE_LOG_INFOis defined OR__INTERNALDEBUGor_INTERNALDEBUGis defined AND_DEBUGor__DEBUGis defined.HAVE_LOG_NO_INFOcan be set by users with-DLOG_NO_INFO, which defaults to OFF in debug and ON in every other configuration.FASTDDS_ENFORCE_LOG_INFOcan be defined by the user and defaults to OFF__INTERNALDEBUGis defined when compiling Fast DDS with-DINTERNAL_DEBUG, which defaults to OFF_INTERNALDEBUGcan be defined by the user. Fast DDS does not define it, nor Fast DDS CMakeLists_DEBUGis defined when using Windows config generators in build type is debug__DEBUGis defined iffCMAKE_BUILD_TYPEis set to exactlyDebug(other casing will not match)This means that a Linux user building in debug with
CMAKE_BUILD_TYPE=DEBUG(or something other than Debug) and with-DINTERNAL_DEBUGcan end up with no log infos. This PR adds an additional check for case 3, which is check for either_DEBUG,__DEBUGor thatNDEBUGis not defined.NDEBUGis actually a C++ standard definition that must be set when building is something other than debug. CMake adds this definition by itself, so no CMakeLists.txt needs to be modified.Signed-off-by: Eduardo Ponz Segrelles eduardoponz@eprosima.com