Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read/Take return NO_DATA if a future change is found [12134] #2074

Merged
merged 4 commits into from
Jul 19, 2021

Conversation

richiware
Copy link
Member

ReadTakeCommand breaks the search of new changes if it found a future change of a writer although there is unread changes from other writers.

@richiware richiware changed the title Read/Take return NO_DATA if a future change is found Read/Take return NO_DATA if a future change is found [12134] Jul 15, 2021
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a regression test?

@MiguelCompany MiguelCompany added this to the v2.3.4 milestone Jul 16, 2021
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Copy link
Member Author

@MiguelCompany regression test added

test/unittest/dds/subscriber/CMakeLists.txt Outdated Show resolved Hide resolved
test/unittest/dds/subscriber/DataReaderTests.cpp Outdated Show resolved Hide resolved
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 3de55e3 into master Jul 19, 2021
@MiguelCompany MiguelCompany deleted the bugfix/12133 branch July 19, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants