Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2066. #2068

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Fixes #2066. #2068

merged 1 commit into from
Jul 14, 2021

Conversation

pablorcum
Copy link
Contributor

@pablorcum pablorcum commented Jul 14, 2021 •
edited
Loading

No description provided.

@pablorcum
Fixes #2066.
abc5dc6 
Signed-off-by: promero <promero@mathworks.com>
MiguelCompany
MiguelCompany approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will skip tests and let the CI just build, as this should not affect tests execution

@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Jul 14, 2021
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany
Copy link
Member

@richiprosima Please test windows

@MiguelCompany MiguelCompany linked an issue Jul 14, 2021 that may be closed by this pull request
DeadlineQoSExample(s) do not compile for QNX due to missing libpthread #2066
Closed
@MiguelCompany
Copy link
Member

Worked well enough. Going in.

Thank you @pablorcum for your contribution!

@MiguelCompany MiguelCompany merged commit a76966f into eProsima:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeadlineQoSExample(s) do not compile for QNX due to missing libpthread
2 participants
@pablorcum @MiguelCompany