Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscription throughput data generation [11964] #2050

Merged
merged 7 commits into from
Jul 8, 2021

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Jul 6, 2021

No description provided.

jparisu added 2 commits July 6, 2021 16:13
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu requested a review from MiguelCompany July 6, 2021 14:15
jparisu added 3 commits July 6, 2021 16:34
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu marked this pull request as ready for review July 6, 2021 14:37
src/cpp/rtps/reader/StatelessReader.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/reader/StatelessReader.cpp Outdated Show resolved Hide resolved
test/blackbox/common/DDSBlackboxTestsStatistics.cpp Outdated Show resolved Hide resolved
Signed-off-by: jparisu <javierparis@eprosima.com>
MiguelCompany
MiguelCompany previously approved these changes Jul 7, 2021
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit.

src/cpp/rtps/reader/StatelessReader.cpp Outdated Show resolved Hide resolved
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 7d52421 into master Jul 8, 2021
@MiguelCompany MiguelCompany deleted the hotfix/subscription-throughput-send-data branch July 8, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants