Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning if cannot open multicast port [11928] #2040

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

richiware
Copy link
Member

If main metadata multicast port cannot be opened, warning to the user because discovery can fail with other applications.

richiware added 2 commits July 2, 2021 09:02
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title Warning if cannot open multicast port Warning if cannot open multicast port [11928] Jul 2, 2021
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would this happen? We are setting socket options (i.e. REUSEADDR) to allow the same port to be open by different applications.

Is it possible to have a regression test?

@richiware
Copy link
Member Author

This happens if another application (not DDS) have the port opened. In my case happened running tests (random port) and sometimes the test tries to open a port owned by Firefox. Then the test fails. With this warning I have see quickly there is no problem about the failed test. And also I think it will be useful for users.

I don't know how to do a regression test of this. Is only a log warning.

Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MiguelCompany added a commit that referenced this pull request Jul 2, 2021
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@richiware
Copy link
Member Author

Tests were passed in #2047.

@richiware richiware merged commit 534e4b3 into master Jul 5, 2021
@richiware richiware deleted the feature/warning-cannot-open-multicast-port branch July 5, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants