Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about Datasharing limitation with Datareader's history size [11926] #2038

Merged
merged 4 commits into from
Jul 5, 2021

Conversation

richiware
Copy link
Member

There is a limitation about Datareader's HistoryQos and Datasharing. In case it is detected, a warning is shown to the user.

richiware added 2 commits July 2, 2021 08:46
…haring.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title Add warning about Datasharing limitation with Datareader's history size Add warning about Datasharing limitation with Datareader's history size [11926] Jul 2, 2021
richiware added 2 commits July 2, 2021 09:56
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MiguelCompany added a commit that referenced this pull request Jul 2, 2021
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@richiware
Copy link
Member Author

Tests were passed in #2047.

@richiware richiware merged commit 163380d into master Jul 5, 2021
@richiware richiware deleted the feature/warning-datasharing-history-size branch July 5, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants