Fix deadlock with LivelinessManager [11925] #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
MiguelCompany
requested changes
Jul 2, 2021
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
|
Reliable Datawriters will never send a heartbeat to Besteffort Datareaders. Only in case of using multicast but I think a Besteffort Datareader will never expect a heartbeat, then it will never do something if received one. |
I am thinking of the case when the liveliness is set to |
After discussing this offline, we will do this in a separate PR. |
MiguelCompany
added a commit
that referenced
this pull request
Jul 2, 2021
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a deadlock when asserting liveliness of a writer (due to a sample was received from it).