Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segmentation fault on discovery server [11922] #2033

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

richiware
Copy link
Member

DSClientEvent accesses the information of PDPSimple without locking its mutex. When this event is running and a new Participant is discovered, a segmentation fault occurs. This PR adds the locking of PDPSimple's mutex.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title Fix segmentation fault on discovery server Fix segmentation fault on discovery server [11922] Jul 2, 2021
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany
Copy link
Member

This PR is only affecting discovery server, and those test have run successfully. Going in.

@MiguelCompany MiguelCompany merged commit 279a776 into master Jul 2, 2021
@MiguelCompany MiguelCompany deleted the bugfix/ds-segment-fault branch July 2, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants