-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mutex lock count on PDPListener [11861] #2020
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
changed the title
Fix mutex lock count on PDPListener
Fix mutex lock count on PDPListener [11861]
Jun 23, 2021
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
force-pushed
the
bugfix/pdp-listener
branch
from
June 23, 2021 14:24
2925831
to
e3fd130
Compare
MiguelBarro
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport 2.2.x 2.1.x 2.0.x |
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Refs 11857. Added regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11857. Fixed issue. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11857. Bonus: fixed PDPServerListener. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11857. Added comments on test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 392defc)
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Refs 11857. Added regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11857. Fixed issue. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11857. Bonus: fixed PDPServerListener. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11857. Added comments on test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 392defc) # Conflicts: # src/cpp/rtps/builtin/discovery/participant/PDPServerListener.cpp
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Refs 11857. Added regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11857. Fixed issue. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11857. Bonus: fixed PDPServerListener. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11857. Added comments on test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 392defc) # Conflicts: # src/cpp/rtps/builtin/discovery/participant/PDPServerListener.cpp # test/blackbox/CMakeLists.txt # test/blackbox/DDSBlackboxTestsDiscovery.cpp
Command
|
MiguelCompany
added a commit
that referenced
this pull request
Jun 24, 2021
* Fix mutex lock count on PDPListener (#2020) * Refs 11857. Added regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11857. Fixed issue. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11857. Bonus: fixed PDPServerListener. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11857. Added comments on test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 392defc) # Conflicts: # src/cpp/rtps/builtin/discovery/participant/PDPServerListener.cpp * Fix conflicts Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Linters Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this pull request
Jun 24, 2021
* Fix mutex lock count on PDPListener (#2020) * Refs 11857. Added regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11857. Fixed issue. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11857. Bonus: fixed PDPServerListener. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11857. Added comments on test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 392defc) # Conflicts: # src/cpp/rtps/builtin/discovery/participant/PDPServerListener.cpp # test/blackbox/CMakeLists.txt # test/blackbox/DDSBlackboxTestsDiscovery.cpp * Fixed conflicts Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Linters Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Fix conflicts on CMakeLists.txt Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.