Fix warnings and segfaults on Win32 builds #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
… 2 const string refs. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
d9c8743 to
36edae7
Compare
|
@Mergifyio backport 2.2.x |
mergify bot
pushed a commit
that referenced
this pull request
May 24, 2021
* Refs 11606. Fixed alignment warnings. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11606. Added ParameterPropertyList_t::push_back method receiving 2 const string refs. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11606. Using new method on PDP and ParticipantProxyData. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11606. Improve thread safety on DataSharingListener. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit d5f3559) # Conflicts: # src/cpp/rtps/builtin/discovery/participant/PDP.cpp
|
Command
|
MiguelCompany
added a commit
that referenced
this pull request
May 26, 2021
* Fix warnings and segfaults on Win32 builds (#1982) * Refs 11606. Fixed alignment warnings. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11606. Added ParameterPropertyList_t::push_back method receiving 2 const string refs. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11606. Using new method on PDP and ParticipantProxyData. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11606. Improve thread safety on DataSharingListener. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit d5f3559) # Conflicts: # src/cpp/rtps/builtin/discovery/participant/PDP.cpp * Fixed rebase conflicts Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests run locally for Win32