Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11278] UDPv6 refactor and tests #1969

Merged
merged 21 commits into from
Jun 2, 2021
Merged

Conversation

JLBuenoLopez
Copy link
Contributor

This PR updates UDPv6 and includes several tests to check this feature. This PR fixes the whitelist interface feature for UDPv6 (fixes #1923).

There was a bug when comparing IPv6. IPv6 address has an scope that is included after the address separated by %. There is a new method that allows the comparison of IPv6 addresses without taking into account the scope. This way the user can simply whitelist using the IPv6 address without having to include the name of the interface so Asio can infer the scope of the given address. It also works if the scope is given.

IPv6 feature is not completely tested so this PR is going to be a draft while some tests are included to ensure that the feature is stable and working in the most usual cases.

@JLBuenoLopez JLBuenoLopez marked this pull request as ready for review May 21, 2021 09:48
@MiguelCompany MiguelCompany requested a review from MiguelBarro May 26, 2021 06:45
@MiguelBarro MiguelBarro force-pushed the bugfix/ipv6-whitelist branch 2 times, most recently from 029a0e6 to 29b7499 Compare May 29, 2021 16:42
JLBuenoLopez and others added 21 commits May 31, 2021 10:23
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
…ress

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
…on Tests

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
…s ignore any statistics management if the buffer is not properly formatted.
@MiguelBarro MiguelBarro force-pushed the bugfix/ipv6-whitelist branch from 7d4196a to b95d604 Compare June 1, 2021 08:44
Copy link
Contributor

@MiguelBarro MiguelBarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 65f2c66 into master Jun 2, 2021
@MiguelCompany MiguelCompany deleted the bugfix/ipv6-whitelist branch June 2, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPv6 Interface Whitelisting Does Not Work [11278]
3 participants