Document and assert RTPS entity pointers lifetime [11579] #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
IkerLuengo
suggested changes
May 17, 2021
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
MiguelCompany
requested changes
May 18, 2021
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
fd5ca17 to
ac7b6ab
Compare
MiguelCompany
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents accessing to an already deleted
RTPSParticipant. This case may arise when an application does:RTPSDomain::stopAll()RTPSDomain::removeRTPSParticipant()with the saved pointer.stopAll()already deleted all the createdRTPSParticipants, so accessing to the memory segment using the pointer obtained on creation is dangerous at best. We can not prevent applications to manipulate the pointer after callingstopAll()(thus breaking the contract), but we definitely should not do so within Fast DDS.