Synchronize TCP reception to wait for RTCP header. [11562] #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
richiware
previously approved these changes
May 13, 2021
|
There are warnings. Please, fix them |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
74cf7c5 to
4baa9eb
Compare
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
68257d4 to
62038a9
Compare
richiware
previously approved these changes
May 14, 2021
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
|
Failing tests are not using TCP. |
|
@mergify backport 2.2.x |
mergify bot
pushed a commit
that referenced
this pull request
May 14, 2021
* Refs 9141. Add unit test for TCP reception of out of sequence header. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 9141. New mutex to protect asio::write calls on TCP. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 9141. Synchronize reception to RTCP. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Fix warning. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Do not show warning on EOF error. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Tests improvements. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Fix number of bytes to skip. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 5a23fc4) # Conflicts: # test/unittest/transport/TCPv4Tests.cpp
|
Command
Hey, I reacted but my real name is @Mergifyio |
MiguelCompany
added a commit
that referenced
this pull request
May 20, 2021
* Synchronize TCP reception to wait for RTCP header (#1957) * Refs 9141. Add unit test for TCP reception of out of sequence header. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 9141. New mutex to protect asio::write calls on TCP. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 9141. Synchronize reception to RTCP. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Fix warning. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Do not show warning on EOF error. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Tests improvements. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Fix number of bytes to skip. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 5a23fc4) # Conflicts: # test/unittest/transport/TCPv4Tests.cpp * Fixing rebase conflicts. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Uncrustify Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
mergify bot
added a commit
that referenced
this pull request
May 20, 2021
* Synchronize TCP reception to wait for RTCP header (#1957) * Refs 9141. Add unit test for TCP reception of out of sequence header. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 9141. New mutex to protect asio::write calls on TCP. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 9141. Synchronize reception to RTCP. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Fix warning. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Do not show warning on EOF error. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Tests improvements. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Fix number of bytes to skip. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 5a23fc4) # Conflicts: # test/unittest/transport/TCPv4Tests.cpp * Fixing rebase conflicts. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Uncrustify Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 10aa9cf)
mergify bot
added a commit
that referenced
this pull request
May 20, 2021
* Synchronize TCP reception to wait for RTCP header (#1957) * Refs 9141. Add unit test for TCP reception of out of sequence header. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 9141. New mutex to protect asio::write calls on TCP. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 9141. Synchronize reception to RTCP. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Fix warning. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Do not show warning on EOF error. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Tests improvements. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Fix number of bytes to skip. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 5a23fc4) # Conflicts: # test/unittest/transport/TCPv4Tests.cpp * Fixing rebase conflicts. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Uncrustify Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 10aa9cf)
MiguelCompany
pushed a commit
that referenced
this pull request
May 21, 2021
* Synchronize TCP reception to wait for RTCP header (#1957) * Refs 9141. Add unit test for TCP reception of out of sequence header. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 9141. New mutex to protect asio::write calls on TCP. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 9141. Synchronize reception to RTCP. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Fix warning. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Do not show warning on EOF error. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Tests improvements. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Fix number of bytes to skip. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 5a23fc4) # Conflicts: # test/unittest/transport/TCPv4Tests.cpp * Fixing rebase conflicts. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Uncrustify Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 10aa9cf) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
MiguelCompany
pushed a commit
that referenced
this pull request
May 21, 2021
* Synchronize TCP reception to wait for RTCP header (#1957) * Refs 9141. Add unit test for TCP reception of out of sequence header. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 9141. New mutex to protect asio::write calls on TCP. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 9141. Synchronize reception to RTCP. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Fix warning. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Do not show warning on EOF error. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Tests improvements. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Fix number of bytes to skip. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11562. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 5a23fc4) # Conflicts: # test/unittest/transport/TCPv4Tests.cpp * Fixing rebase conflicts. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Uncrustify Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 10aa9cf) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix issue #1268 by always waiting for the RTCP header, consuming bytes if they come unordered.