Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection of data and notification to listeners NETWORK_LATENCY [10791] #1952

Merged
merged 18 commits into from
May 13, 2021
Merged

Collection of data and notification to listeners NETWORK_LATENCY [10791] #1952

merged 18 commits into from
May 13, 2021

Conversation

MiguelCompany
Copy link
Member

No description provided.

@MiguelCompany MiguelCompany requested a review from MiguelBarro May 10, 2021 06:12
@MiguelCompany MiguelCompany force-pushed the feature/statistics/rtps/network-latency branch from 55c0d3f to af7505a Compare May 10, 2021 06:38
@MiguelCompany
Refs 10791. Added RTPSStatisticsMessages.hpp.
4e779e9 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10791. Improve RTPSMessageCreator::addSubmessageHeader.
55c5e24 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10791. RTPSMessageGroup adds statistics submessage at the end.
3227095 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10791. Account for new submessage on RTPSWriter::calculateMaxDat…
18e85db 
…aSize.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10791. MessageReceiver processing of new submessage.
740ee6d 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10791. Shared mem transport reports correct locator kind.
e75695f 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10791. Do not process network statistics for SHM.
c5817f0 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10791. MessageReceiver takes reception locator.
d8424be 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10791. Statistics submessage filled from transport.
87f3cd4 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11450. Extend submessage with byte count.
5d327ff 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11450. SharedMemTransport removes statistics submessage.
211b519 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11450. Method to read a statistics submessage.
d3e59d9 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11450. Processing moved to StatisticsParticipantImpl.
561ab42 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10791. Modified test to expect network_latency events.
412df88 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10791. Calling listener.
0fcc5e3 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10791. Linters.
443a152 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11450. Ensure space for statistics submessage.
4d79b04 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the feature/statistics/rtps/network-latency branch from 2e2a688 to 4d79b04 Compare May 12, 2021 05:33
@MiguelCompany
Copy link
Member Author

@richiprosima Please test mac

MiguelBarro
MiguelBarro reviewed May 12, 2021
View reviewed changes
src/cpp/statistics/rtps/messages/RTPSStatisticsMessages.hpp Outdated
@@ -0,0 +1,195 @@
// Copyright 2016 Proyectos y Sistemas de Mantenimiento SL (eProsima).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update date

MiguelBarro
MiguelBarro suggested changes May 12, 2021
View reviewed changes
Copy link
Contributor

@MiguelBarro MiguelBarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please solve the minor issues

@MiguelCompany
Refs 10791. Adressed peer review comments.
673c41f 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Copy link
Member Author

Please solve the minor issues

Done in 673c41f

@MiguelCompany MiguelCompany temporarily deployed to codecov May 12, 2021 13:19 Inactive
MiguelBarro
MiguelBarro approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@MiguelBarro MiguelBarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 7e12e8f into master May 13, 2021
@MiguelCompany MiguelCompany deleted the feature/statistics/rtps/network-latency branch May 13, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelBarro MiguelBarro MiguelBarro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @MiguelBarro