Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10796] RESENT_DATAS tests & implementation #1936

Merged
merged 11 commits into from
May 1, 2021
Merged

[10796] RESENT_DATAS tests & implementation #1936

merged 11 commits into from
May 1, 2021

Conversation

MiguelBarro
Copy link
Contributor

@MiguelBarro MiguelBarro commented Apr 27, 2021 •
edited
Loading

There is a piggyback now Statistics' for_each_listener methods use temporary lists to prevent collection traversal with the mutex locked.

@MiguelBarro MiguelBarro temporarily deployed to codecov April 27, 2021 08:02 Inactive
@MiguelBarro MiguelBarro temporarily deployed to codecov April 27, 2021 08:10 Inactive
@MiguelBarro MiguelBarro force-pushed the feature/statistics/rtps/resend_datas_impl branch from cff45a3 to 0aa16bc Compare April 27, 2021 08:39
@MiguelBarro MiguelBarro force-pushed the feature/statistics/rtps/resend_datas_impl branch from 0aa16bc to 83740f2 Compare April 27, 2021 08:45
@MiguelBarro MiguelBarro force-pushed the feature/statistics/rtps/resend_datas_impl branch from 83740f2 to 7d1b4d3 Compare April 27, 2021 09:32
@MiguelBarro MiguelBarro temporarily deployed to codecov April 27, 2021 09:32 Inactive
@MiguelBarro MiguelBarro force-pushed the feature/statistics/rtps/resend_datas_impl branch from 7d1b4d3 to fbf8b94 Compare April 27, 2021 09:45
@MiguelBarro MiguelBarro temporarily deployed to codecov April 27, 2021 09:45 Inactive
@MiguelCompany MiguelCompany force-pushed the feature/statistics/impl branch from 91f0204 to 153b1ab Compare April 28, 2021 05:13
@MiguelBarro MiguelBarro force-pushed the feature/statistics/rtps/resend_datas_impl branch from fbf8b94 to f8febef Compare April 28, 2021 05:42
@MiguelBarro MiguelBarro temporarily deployed to codecov April 28, 2021 06:10 Inactive
JLBuenoLopez
JLBuenoLopez previously approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelBarro MiguelBarro temporarily deployed to codecov April 28, 2021 07:59 Inactive
Base automatically changed from feature/statistics/impl to master April 28, 2021 08:50
@MiguelBarro MiguelBarro force-pushed the feature/statistics/rtps/resend_datas_impl branch from 65670e2 to 92c746f Compare April 28, 2021 11:09
@MiguelBarro MiguelBarro force-pushed the feature/statistics/rtps/resend_datas_impl branch from 92c746f to f17809f Compare April 28, 2021 11:12
@MiguelCompany
Fix workflow
f70c8c9 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany temporarily deployed to codecov April 28, 2021 13:29 Inactive
@MiguelCompany
Add BlackboxTests_DDS_PIM to workflow
c69826b 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany temporarily deployed to codecov April 28, 2021 15:28 Inactive
@MiguelCompany
Add DomainParticipantStatisticsListenerTests to workflow
8b91282 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany temporarily deployed to codecov April 28, 2021 17:07 Inactive
@MiguelCompany MiguelCompany temporarily deployed to codecov April 29, 2021 14:42 Inactive
@MiguelBarro MiguelBarro force-pushed the feature/statistics/rtps/resend_datas_impl branch from 68dd4f9 to 5f554e2 Compare April 30, 2021 08:44
@MiguelCompany MiguelCompany temporarily deployed to codecov April 30, 2021 08:54 Inactive
@MiguelCompany MiguelCompany merged commit 1b3bc89 into master May 1, 2021
@MiguelCompany MiguelCompany deleted the feature/statistics/rtps/resend_datas_impl branch May 1, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@JLBuenoLopez JLBuenoLopez JLBuenoLopez left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelBarro @MiguelCompany @JLBuenoLopez