Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly update memory policy on writers and readers [11348] #1931

Merged
merged 5 commits into from
Apr 23, 2021
Merged

Correctly update memory policy on writers and readers [11348] #1931

merged 5 commits into from
Apr 23, 2021

Conversation

MiguelCompany
Copy link
Member

This PR fixes an assertion on writers with bounded types and PREALLOCATED_WITH_REALLOC policy, and also sets PREALLOCATED on readers with bounded types and PREALLOCATED_WITH_REALLOC

@MiguelCompany
Refs 11347. Add mem_policy setter to PubSubWriter.
fb62659 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11347. Extend PubSubHistory tests with memory mode.
72138c7 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11347. Fixed DataWriterImpl.
b26589b 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11347. Apply changes on DataReaderImpl.
a5bcf60 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added the no-aarch Skip build & test for aarch64 label Apr 23, 2021
@MiguelCompany MiguelCompany added this to the v2.3.1 milestone Apr 23, 2021
@MiguelCompany MiguelCompany changed the title Correctly update memory policy on writers and readers Correctly update memory policy on writers and readers [11348] Apr 23, 2021
@MiguelCompany
Refs 11348. Linters.
96bcbc9 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
IkerLuengo
IkerLuengo approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit efd1ba3 into master Apr 23, 2021
@MiguelCompany MiguelCompany deleted the hotfix/mem-policy-change branch April 23, 2021 08:49
@MiguelCompany MiguelCompany mentioned this pull request Apr 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IkerLuengo IkerLuengo IkerLuengo approved these changes

Assignees
No one assigned
Labels
no-aarch Skip build & test for aarch64
Projects
None yet
Milestone
v2.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @IkerLuengo