Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow datasharing writer to remove samples in the middle of history [11308] #1926

Merged
merged 5 commits into from
Apr 21, 2021

Conversation

MiguelCompany
Copy link
Member

No description provided.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
…ory.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany changed the title Allow datasharing writer to remove samples in the middle of history Allow datasharing writer to remove samples in the middle of history [11308] Apr 21, 2021
@MiguelCompany
Copy link
Member Author

@richiprosima Please test mac

IkerLuengo
IkerLuengo previously approved these changes Apr 21, 2021
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@MiguelCompany MiguelCompany merged commit 5beca39 into master Apr 21, 2021
@MiguelCompany MiguelCompany deleted the bugfix/datasharing-volatile branch April 21, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants