[10804 ] Collection of data and notification to listeners DISCOVERED_ENTITY #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cf3d9a to
7339212
Compare
JLBuenoLopez
suggested changes
Apr 21, 2021
180a0cb to
b5d57f4
Compare
db59896 to
a0d0cbc
Compare
a0d0cbc to
807e98e
Compare
807e98e to
6ebafbc
Compare
6ebafbc to
2ecd25a
Compare
added 7 commits
April 26, 2021 09:15
2ecd25a to
09ee17a
Compare
…osition on statistics api
MiguelCompany
pushed a commit
that referenced
this pull request
Apr 28, 2021
…ENTITY (#1920) * [10804] DISCOVERED_ENTITY callback implementation * [10804] DISCOVERED_ENTITY testing implementation * solving gcc issues * [10804] rebase * [10804] addressing reviewer comments * [10804] solving namespace issues * [10804] preventing discovery ABBAs by using a devoted participant's statistics mutex * [10804] Turning EventKind argument into uin32_t to simplify mask composition on statistics api
MiguelCompany
added a commit
that referenced
this pull request
Apr 28, 2021
* Statistics QoS implementation (#1858) * Refs #10991: eprosima::fastdds::statistics::dds::DataWriterQos() implementation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10991: eprosima::fastdds::statistics::dds::DataReaderQos() implementation Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10991: remove compilation guards. Implement testing of pull mode property Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10991: uncrustify Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Implementation of both narrow methods (#1870) * Refs #11013: narrow implementations Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #11013: remove log error from test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #11013: uncrustify Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #11013: apply review suggestion Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Fix building errors in Windows when `FASTDDS_STATISTICS` CMake option is enabled (#1879) * Refs #11056: fix Windows warnings: conditional expression is constant Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #11056: fix MOCK_METHOD macro in RTPSStatisticsTests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #11056: fix StatisticsDomainParticipantTests linking errors in Windows Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #11056: uncrustify Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #11056: apply review suggestion Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Action for coverage (#1887) * Refs 11098: Action for coverage Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Add colcon.meta Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs 11098: Install gmock Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs 11098: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Enable statistics tests (#1892) Signed-off-by: EduPonz <eduardoponz@eprosima.com> * [10714] Create and delete domainParticipant implementation (#1885) * Refs #10714: add environment variable Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10714: add StatisticsDomainParticipant tests checking create_participant Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10998: add methods to statistics domainParticipant (create participant) Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10998: create statistics DomainParticipant if the CMake flag is enabled Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #11043: add methods to statistics domainParticipant (delete participant) Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #11043: call delete_statistics_builtin_entities in delete_participant Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10998: add CreateParticipantWithInvalidTopicName test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10714: uncrustify Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10714: fix Linux build errors Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Solving unittest CMake issue on windows: fastcdr dependency isn't propagated Co-authored-by: Miguel Barro <miguelbarro@eprosima.com> * Statistics module rtps listener management (#1884) * [10809] [10810] CMake framework setup & RTPSWriter|Reader implementation. * Add RTPSParticipantImpl implementation and solve sync issues. * listener management testing operational * solve build issue when statistics module is disabled * [10794] Extending auxiliary members for Writers and Readers * RTPS_SENT callback implementation * DATA_COUNT implementation * Test update to handle DATA_COUNT callbacks * ACKNACK_COUNT implementation * Test update to handle ACKNACK_COUNT callbacks * Solving gcc warnings * changes to increase coverage * Linter pass * Reorder Statistics auxiliary apis to avoid duplications * Review: adapting include policy to guidelines * renaming apis to emphasize rtps nature * review: renaming variables for descriptiveness sake * review: solving doxygen typos * addressing reviewers comments * updating dummy statistics api * [10797] HEARTBEAT_COUNT callback implementation (#1911) * Reorder Statistics auxiliary apis to avoid duplications * HEARTBEAT_COUNT callback implementation * Reordering mock calls to avoid uninteresting call warning * avoid gmock old syntax * Split the mock callback into individual ones * [10797] addressing reviewer comments * [10797] addressing reviewer comments * [10799] NACKFRAG_COUNT callback implementation (#1915) * [10799] NACKFRAG_COUNT callback implementation * Solving ABBA in RTPS_SENT callback * [10799] Updating the test to include the NACKFRAG_COUNT callback * [10799] solving gcc warnings * Removing debugging traces * [10799] Improve filtering procedure to make it transport independent (number of filter callbacks doesn't affect filtering result). * linter pass * [10799] addressing reviewer's comments * [10800] - Collection of data and notification to listeners GAP_COUNT (#1919) * [10800] GAP_COUNT callback implementation * [10800] GAP_COUNT test implementation * Modify github action to only run rtps statistics tests * [10800] addressing reviewer comments * [10800] rebase * [10804 ] Collection of data and notification to listeners DISCOVERED_ENTITY (#1920) * [10804] DISCOVERED_ENTITY callback implementation * [10804] DISCOVERED_ENTITY testing implementation * solving gcc issues * [10804] rebase * [10804] addressing reviewer comments * [10804] solving namespace issues * [10804] preventing discovery ABBAs by using a devoted participant's statistics mutex * [10804] Turning EventKind argument into uin32_t to simplify mask composition on statistics api * Enable/Disable statistics datawriter implementation (#1922) * Refs #10807: check that the topic name is valid Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: check QoS consistency Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: register statistics types Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10801: create statistics topic Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10801: remove return code from register_type Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: fix PubSubReader to use specific domain id with statistics blackbox tests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: use EXPECT_TRUE instead of EXPECT_EQ (the latter compares the shared pointers and not the pointed objects and thus fails) Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: fix enable_statistics_datawriter to handle correctly topic creation and pass the object so create_datawriter can be called correctly Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: refactor transform_topic_name_alias Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: fix EnableDisableStatisticsDataWriters test -> delete_participant removes all contained statistics entities Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: disable_statistics_datawriter implementation. Fix enable_statistics_datawriter to check if the DataWriter has been already created Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: check register type to ensure there is not another type already regitered with the reserved name Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: change topic_desc check for an assert Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: modify Statistics Blackbox to use all aliases (coverage transform_topic_name_alias) Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: use domain id depending on the process id Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: remove logError Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: add CreateParticipantFailureIncompatibleType test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: fix enable_statistics_datawriter return code Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: add CreateParticipantFailureIncompatibleTopic test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: refactor find_or_create_topic_and_type Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: complete tests. Ensure that the test cleans before finishing Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: mock Publisher class Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: add EnableStatisticsDataWriterFailureCreateDataWriter test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: add new case to test: enable_statistics_datawriter when the Topic and Type are already correctly registered within the participant Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: remove dynamic_cast check and add TODO message Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: mock create_datawriter method correctly Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: fix EnableStatisticsDataWriterFailureCreateDataWriter test (delete_participant) Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807. Fix build issues on Windows. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #10807: correctly mock delete_datawriter Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: add DisableStatisticsDataWriterFailureDeleteDataWriter test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: mock domainParticipant class Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: add DisableStatisticsDataWriterFailureDeleteTopic test. Complete DisableStatisticsDataWriterFailureDeleteDataWriter test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: fix Clang building issues Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: fix link issue caused by rebase Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: fix pull mode property name and corresponding test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: update coverage job to only run statistics tests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: add DisableStatisticsDataWriterWithIncompatibleTopicAndType test. Refactor in the other unit tests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: improve coverage by making auxiliary methods noexcept Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: refactor to move implementations to DomainParticipantImpl Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: fix mock delete_topic tests. Mock DomainParticipantImpl class Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: remove DisableStatisticsDataWriterWithIncompatibleTopicAndType test Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: refactor delete topic and type Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: Guard DomainParticipantImpl Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: fix build errors when FASTDDS_STATISTICS is not enabled Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #10807: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com> * Statistics link between DDS and RTPS layers (#1924) * MOCK_METHOD->MOCK_METHOD1 Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Added empty DomainParticipantStatisticsListener. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Fixed DataWriter header guard. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Added empty DomainParticipantStatisticsListenerTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Added implementation of DomainParticipantStatisticsListenerTests. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Added implementation of DomainParticipantStatisticsListener. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Added simple blackbox test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Join transform and check topic name. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Add listener. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Link / unlink statistics writer to listener. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Proxy methods to create PublisherImpl and SubscriberImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Alias namespace. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Basic statistics PublisherImpl and SubscriberImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Adressed partial review. * Refs 11273. Proxy method to create DataWriterImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. PublisherImpl creates statistics DataWriterImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Add / remove listener on DataWriterImpl enable / disable. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Blackbox test waits for data. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Extend blackbox test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Proxy method to create DataReaderImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. SubscriberImpl creates statistics DataReaderImpl Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Add / remove listener on DataReaderImpl enable / disable. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Added DomainParticipantImpl::is_statistics_topic_name Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Do not add listeners to builtin topics. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Link listener to participant. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Avoid ABBA on listener Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Avoid ABBA on StatisticsBase. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Improving test Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Add sender_guid to participant sendSync. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Utilities for statistics builtin GUIDs. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Method on_rtps_sent avoids statistics builtin endpoints. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. PublisherImpl method to create DataWriter from DataWriterImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. DomainParticipantImpl keeps builtin_publisher_impl_ Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Proxy method to create RTPS writer. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Keep entity_id on DataWriterImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Added API on RTPSDomain to create writer with specific entity id. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Statistics RTPS writers created with specific entity_id. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Enable RTPS_SENT on blackbox test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Fix alignment issue on Entity2LocatorTrafficPubSubType. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Fix unused variable warning. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Linters. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Fixed build with statistics disabled. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Header suggestions on sources. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: José Luis Bueno López <69244257+JLBuenoLopez-eProsima@users.noreply.github.com> * Refs 11273. Protect against double enable. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Fixed warning on Windows. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Custom entity id indicates keyed writer. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #11273: fix DomainParticipantImpl mock class Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs 11273. Make RTPSStatisticsTests compliant with old versions of gmock. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 11273. Check on delete_statistics_builtin_entities. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #11273: fix mock statistics tests Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs #11273: linters Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Co-authored-by: José Luis Bueno López <69244257+JLBuenoLopez-eProsima@users.noreply.github.com> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Update statistics workflow Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: José Luis Bueno López <69244257+JLBuenoLopez-eProsima@users.noreply.github.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: Miguel Barro <miguelbarro@eprosima.com> Co-authored-by: MiguelBarro <45819833+MiguelBarro@users.noreply.github.com> Co-authored-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #1919