Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and expose pull mode #1891

Merged
merged 16 commits into from
Apr 13, 2021
Merged

Fix and expose pull mode #1891

merged 16 commits into from
Apr 13, 2021

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Apr 7, 2021 •
edited
Loading

This PR fixes the logic on StatefulWriter when m_pushMode is false and exposes it through property fastdds.push_mode

Documentation PR on eProsima/Fast-DDS-docs#256

@MiguelCompany
Refs 10716. Fix on send_any_unsent_changes.
9abc3e7 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10716. Always use push mode for best effort readers.
475cb35 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10716. Refactor heartbeat sending.
4ff2db0 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10716. Always push on intraprocess.
056cc2d 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 10716. Improve synchronous delivery.
9da4ca4 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11113. Fixed discovery tests.
52af615 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11113. Fixed RequestReplier tests.
94b9cd6 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11113. Correctly enabling datasharing on request replier.
3ed636c 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11113. Added pull_mode infrastructure to blackbox tests.
1832830 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11113. Added pull_mode to PubSubBasic blackbox.
1f1903b 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11113. Refactor on DataWriterTests.InvalidQos.
7ee09bc 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11113. Added pull mode inconsistencies to DataWriterTests.Invali…
2be4c07 
…dQos.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11113. Added pull mode consistency checks.
d0171fb 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11113. Set push mode value on RTPS writer creation.
76b86dd 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Apr 7, 2021
@MiguelCompany
Refs 11113. Uncrustify.
be3fab0 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany removed the skip-ci Automatically pass CI label Apr 7, 2021
@MiguelCompany MiguelCompany marked this pull request as ready for review April 7, 2021 15:11
@MiguelCompany
Refs 11113. Fixed PubSubBasic.PubSubAsNonReliableHelloworld.
2b20e1d 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the bugfix/expose-pull-mode branch from 713a617 to 2b20e1d Compare April 7, 2021 17:17
JLBuenoLopez
JLBuenoLopez approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CI failures seem unrelated to this PR and these tests are known to be flaky.

@MiguelCompany MiguelCompany merged commit e0ba220 into master Apr 13, 2021
@MiguelCompany MiguelCompany deleted the bugfix/expose-pull-mode branch April 13, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @JLBuenoLopez