Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using reference after removing item on LivelinessManager [11019] #1873

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Avoid using reference after removing item on LivelinessManager [11019] #1873

merged 2 commits into from
Apr 23, 2021

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Mar 29, 2021 •
edited
Loading

Port of #1872 to master

@MiguelCompany
Refs 11017. Avoid using reference after removing item.
a69f312 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 11017. Uncrustify.
d739ec3 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Copy link
Member Author

@richiprosima Please test this

JLBuenoLopez
JLBuenoLopez approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JLBuenoLopez JLBuenoLopez added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Apr 23, 2021
@MiguelCompany MiguelCompany merged commit d880389 into master Apr 23, 2021
@MiguelCompany MiguelCompany deleted the hotfix/liveliness-manager/master branch April 23, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @JLBuenoLopez