Allow fully qualified name in TypeDescriptor [11063] #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed that this PR #1345 attempted to solve the same problem. Would you let me know what's wrong with my PR? |
MiguelCompany
requested changes
Apr 5, 2021
There was a problem hiding this comment.
The logic looks good to me.
Please add some unit tests here
According to the DDS-XTypes spec 7.5.2.4.10, the name of TypeDescriptor should be the fully qualified name, which is the concatenation of module names with the name of a type inside of those modules. This change will allow an object of DynamicTypeBuilder to set a type name that contains colon in it. Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com>
|
I've added a few test cases and fixed the DCO and linters. Would you please review it again? |
|
@richiprosima Please test this |
|
@Mergifyio backport 2.2.x 2.1.x 2.0.x |
mergify bot
pushed a commit
that referenced
this pull request
Jun 9, 2021
* Allow fully qualified name in TypeDescriptor According to the DDS-XTypes spec 7.5.2.4.10, the name of TypeDescriptor should be the fully qualified name, which is the concatenation of module names with the name of a type inside of those modules. This change will allow an object of DynamicTypeBuilder to set a type name that contains colon in it. Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com> * Try to fix linters Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com> * Add some unit tests for type descriptor names Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com> * Fix linters Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com> (cherry picked from commit 61267e3)
mergify bot
pushed a commit
that referenced
this pull request
Jun 9, 2021
* Allow fully qualified name in TypeDescriptor According to the DDS-XTypes spec 7.5.2.4.10, the name of TypeDescriptor should be the fully qualified name, which is the concatenation of module names with the name of a type inside of those modules. This change will allow an object of DynamicTypeBuilder to set a type name that contains colon in it. Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com> * Try to fix linters Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com> * Add some unit tests for type descriptor names Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com> * Fix linters Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com> (cherry picked from commit 61267e3)
mergify bot
pushed a commit
that referenced
this pull request
Jun 9, 2021
* Allow fully qualified name in TypeDescriptor According to the DDS-XTypes spec 7.5.2.4.10, the name of TypeDescriptor should be the fully qualified name, which is the concatenation of module names with the name of a type inside of those modules. This change will allow an object of DynamicTypeBuilder to set a type name that contains colon in it. Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com> * Try to fix linters Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com> * Add some unit tests for type descriptor names Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com> * Fix linters Signed-off-by: Yangbo Long <yangbo.long.mav@gmail.com> (cherry picked from commit 61267e3)
|
Command
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the DDS-XTypes spec 7.5.2.4.10, the name of TypeDescriptor
should be the fully qualified name, which is the concatenation of
module names with the name of a type inside of those modules.
This change will allow an object of DynamicTypeBuilder to set a type
name that contains colon in it. Sometimes it's necessary to use a fully
qualified name in dynamic types to communicate to some existing
ros2 topic directly.
Related issue: https://gitmemory.com/issue/eProsima/Fast-RTPS-Gen/21/603785610