Fix for late-joiners KEEP_LAST, RELIABLE, TRANSIENT_LOCAL [8986] #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lauramg15
commented
Jul 30, 2020
- New large data volatile blackbox tests
- New large data transient local blackbox tests
- New blackbox tests to check #8896 bug (Transient Local, Reliable, Keep Last 1)
- Change the Subscriber History condition to check if the History is Full (Fix for the #8896 bug)
added 2 commits
July 30, 2020 12:56
* Large data volatile tests * Large data transient local tests * Tests to check #8896 bug (Transient Local, Reliable, Keep Last 1) Signed-off-by: Laura Martin <laura@eprosima.com>
Signed-off-by: Laura Martin <laura@eprosima.com>
0276663 to
e84c8fe
Compare
|
Build status:
|
MiguelCompany
requested changes
Jul 30, 2020
added 2 commits
July 31, 2020 09:15
Signed-off-by: Laura Martin <laura@eprosima.com>
Signed-off-by: Laura Martin <laura@eprosima.com>
MiguelCompany
approved these changes
Jul 31, 2020
|
Build status:
|
|
Unrelated failures. Going in! |
lauramg15
added a commit
that referenced
this pull request
Aug 3, 2020
* Refs #8896 Add Blackbox Tests * Large data volatile tests * Large data transient local tests * Tests to check #8896 bug (Transient Local, Reliable, Keep Last 1) Signed-off-by: Laura Martin <laura@eprosima.com> * Refs #8896 Fix history full check in SubscriberHistory Signed-off-by: Laura Martin <laura@eprosima.com> * Refs #8986 Requested Changes Signed-off-by: Laura Martin <laura@eprosima.com> * Refs #8986 Separate HistoryAttributes calculation to a separate method Signed-off-by: Laura Martin <laura@eprosima.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Aug 4, 2020
* Fix for late-joiners KEEP_LAST, RELIABLE, TRANSIENT_LOCAL (#1314) * Refs #8896 Add Blackbox Tests * Large data volatile tests * Large data transient local tests * Tests to check #8896 bug (Transient Local, Reliable, Keep Last 1) Signed-off-by: Laura Martin <laura@eprosima.com> * Refs #8896 Fix history full check in SubscriberHistory Signed-off-by: Laura Martin <laura@eprosima.com> * Refs #8986 Requested Changes Signed-off-by: Laura Martin <laura@eprosima.com> * Refs #8986 Separate HistoryAttributes calculation to a separate method Signed-off-by: Laura Martin <laura@eprosima.com> * Uncrustify Signed-off-by: Laura Martin <laura@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.