Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSRF testing patches #1241

Merged
merged 17 commits into from
Aug 5, 2020
Merged

OSRF testing patches #1241

merged 17 commits into from
Aug 5, 2020

Conversation

MiguelBarro
Copy link
Contributor

Includes the commits:

@MiguelBarro MiguelBarro self-assigned this May 29, 2020
@MiguelBarro MiguelBarro requested a review from MiguelCompany May 29, 2020 11:03
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelBarro MiguelBarro force-pushed the ros2-eloquent-testing branch 2 times, most recently from 8168118 to 05f9f74 Compare June 26, 2020 15:48
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelBarro MiguelBarro force-pushed the ros2-eloquent-testing branch from 3184ee5 to 5e76c6a Compare July 2, 2020 14:18
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelBarro MiguelBarro force-pushed the ros2-eloquent-testing branch from 5e76c6a to f9a2432 Compare July 2, 2020 17:50
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelBarro MiguelBarro force-pushed the ros2-eloquent-testing branch from 728c09e to 82cef71 Compare July 5, 2020 15:19
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelBarro MiguelBarro force-pushed the ros2-eloquent-testing branch from 82cef71 to b55bfbf Compare July 5, 2020 21:29
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelBarro MiguelBarro force-pushed the ros2-eloquent-testing branch 2 times, most recently from 94c1421 to 1c895d2 Compare July 5, 2020 23:47
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelBarro MiguelBarro force-pushed the ros2-eloquent-testing branch from 1c895d2 to ab3a83f Compare July 6, 2020 10:16
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelBarro MiguelBarro force-pushed the ros2-eloquent-testing branch from ab3a83f to 2026a7c Compare July 6, 2020 11:24
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelBarro MiguelBarro mentioned this pull request Jul 9, 2020
Merged
MiguelBarro and others added 3 commits August 3, 2020 11:49
@MiguelBarro
Server-Client trimming form discovery info update (#1102)
7e4b77a 
* Changes to repair the BACKUP participant operation

* Solving persistence guid issue on EDP writer creation.

* Solving gcc compilation issues

* Solving clang compilation issues. Gcc outwits Clang by far.

* Solving duplicated guid issues and debugging leads.

* Solve ABBA between PDP mutex and PDP and EDP writer ones on trimming.

* detect port collisions on server-client architecture

* Remove workaround to prevent guid prefix duplication issues

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro
Repairing client-server BACKUP operation (#1091)
b7053d2 
* Changes to repair the BACKUP participant operation

* Solving persistence guid issue on EDP writer creation.

* Solving gcc compilation issues

* Solving clang compilation issues. Gcc outwits Clang by far.

* Avoiding using C++ attributes to clarify a switch fallthrough scenario.

Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Solved client-server discovery trimming issue on participant drop.
7ad0c87 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
Enforcing uncrustify requested changes.
c93275e 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro MiguelBarro force-pushed the ros2-eloquent-testing branch from 84bfcc4 to f6411f6 Compare August 3, 2020 10:44
@MiguelBarro MiguelBarro force-pushed the ros2-eloquent-testing branch from f6411f6 to 7d20533 Compare August 3, 2020 11:17
@MiguelBarro MiguelBarro force-pushed the ros2-eloquent-testing branch from 7d20533 to a0f1ae6 Compare August 3, 2020 11:36
lauramg15
lauramg15 suggested changes Aug 3, 2020
View reviewed changes
include/fastrtps/qos/ParameterTypes.h Outdated Show resolved Hide resolved
include/fastrtps/qos/ParameterTypes.h Outdated Show resolved Hide resolved
include/fastrtps/qos/ParameterTypes.h Outdated Show resolved Hide resolved
include/fastrtps/qos/ParameterTypes.h Outdated Show resolved Hide resolved
include/fastrtps/qos/ParameterTypes.h Outdated Show resolved Hide resolved
include/fastrtps/rtps/resources/AsyncWriterThread.h Outdated Show resolved Hide resolved
@MiguelBarro MiguelBarro force-pushed the ros2-eloquent-testing branch 3 times, most recently from 8c240a6 to 1049335 Compare August 3, 2020 12:15
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Solving gcc warnings.
71a4e02 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@MiguelBarro MiguelBarro force-pushed the ros2-eloquent-testing branch from 1049335 to 71a4e02 Compare August 3, 2020 14:53
Addressing uncrustify requirements
a9c3918 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Miguel Barro added 2 commits August 3, 2020 18:19
solving gcc warnings.
db6b79b 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
solving doxygen errors.
3769dcb 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Addressing uncrustify and doxygen requirements.
171fa03 
Signed-off-by: Miguel Barro <miguelbarro@eprosima.com>
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@EduPonz
Copy link

EduPonz commented Aug 5, 2020

Linux job was aborted because all security test are expected to failed by timeout due to incompatibility with OpenSSL version on CI. PR compiles without any warnings in Linux and all tests passed in the other 2 platforms. I'd say it's safe to merge

@MiguelCompany MiguelCompany merged commit f69ec3e into ros2-eloquent Aug 5, 2020
@MiguelCompany MiguelCompany deleted the ros2-eloquent-testing branch August 5, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillemsen jwillemsen jwillemsen left review comments

@lauramg15 lauramg15 lauramg15 approved these changes

@MiguelCompany MiguelCompany Awaiting requested review from MiguelCompany

Assignees

@MiguelBarro MiguelBarro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MiguelBarro @richiware @EduPonz @jwillemsen @lauramg15 @MiguelCompany