Store endpoint GUID from message <1.9.x> [7610] #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build status:
|
|
Passes the communication tests between FastRTPS and Connext: |
|
Build status:
|
MiguelCompany
approved these changes
Feb 15, 2020
IkerLuengo
added a commit
that referenced
this pull request
Feb 17, 2020
This is a port of the bugfix #1015
IkerLuengo
added a commit
that referenced
this pull request
Feb 20, 2020
This is a port of the bugfix #1015
IkerLuengo
added a commit
that referenced
this pull request
Feb 28, 2020
This is a port of the bugfix #1015
MiguelCompany
pushed a commit
that referenced
this pull request
Mar 3, 2020
* Refs 7529 Port of PR 965 2fb801734 Ref. 5750 clear QoS instead of reconstruct 39cb3e5 apply review suggestions 50dbc8c Refs #7305. Revert test modifications to old API ccec5bd Refs.7305 Restore API on QosPolicies 4c2b426 Refs #7305. Style on PKIDH.cpp ece3c00 Refs #7305. Using ParameterList::read_guid_from_cdr_msg on PKIDH. ad52820 Refs #7305. Style on ParameterList.cpp 582be58 Refs #7305. Added ParameterList::read_guid_from_cdr_msg. e1ccfea Refs #7305. Styling on WriterProxyData. b7fa7a8 Refs #7305. Styling on ReaderProxyData. 4471db2 Refs #7305. Styling on ParticipantProxyData. 3bc368a Refs #7305. Avoid duplicate code on ParameterList.cpp 419108b Refs #7305. Uncrustify QosPolicies. d2ba714 Refs #7305. Uncrustify ParameterTypes d9260b6 Ref. 5750 unused variable warning removal 9200aa3 Ref. 5750 ProxyDatas don't need data limits anymore f2f22d4 Ref. 5750 Removing warnings 15359a7 Ref. 5750 Move comon code of reading messages to ParameterLists e29cbbf Ref. 5750 ParameterType checks size when reading from message 3e47f99 correct string size alignment 4feb3b8 Remove unused method on ParameterList 90c4d76 Uncrustify CDRMessage e4b18c3 Correct logic error on SerializedPayload::operator== ed797ae Reduce code duplication in CDRMessage::add_string 6c738a6 Remove compilation warnings on Windows 0dbaa8f Correct valgrind errors c5dc730 remove compilation warning abb81b2 Correct security manager message reading routine 0d70e0b Correct compilation warnings c18633d Ref. 5750 correct compilations on mocks 76ffe3d Ref. 5750 correct compilation with security option 12e6439 Ref. 5750 Remove unused ParameterList::readParameterListfromCDRMsg 0f7e175 Ref. 5750 remove obsolete code 0ae0848 Ref. 5750 testing dynamic data size limits a7031bd Ref. 5750 Improve properties' modifications 6725e35 size limit on PartitionQosPolicy 3d75fb1 Ref. 5750 more initialize data limits on WriterProxyData and ReaderProxyData ce38603 Ref. 5750 initialize data limits on WriterProxyData and ReaderProxyData 88363df Ref. 5750 group data limits in a new struct 5655564 Ref. 5750 max size-aware ParameterPropertyList_t 2b37372 Ref. 5750 Make UserData aware of it own size 2da140e Ref. 5750 avoid allocations on deserialize ef268f2 Ref. 5750 Make WriterProxyData deserialize its messages dd79e00 Ref. 5750 Make ReaderProxyData deserialize its messages e7aa067 Ref. 5750 Make ParticipantProxyData deserialize its messages df1ebae Ref. 5750 make data types deserialize themselves 2a6b2a6 Ref. 5750 XML schema for variable size parameters' max size * uncrustify * merge latest commits from #1003 Includes the following commits * 752b865 reset 'hasChanged' to default value on clear * de0f4e7 correct reading of TypeConsistencyEnforcement Also includes some corrections to leave objects on default state when QosPolicies::clear() * Refs 7529 Correct missing override tag * Store endpoint GUID from message This is a port of the bugfix #1015 * Initialize dynamic types on new ProxyData ctor * Refs 7529. Apply review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #1014
After #1003 the Endpoint GUID received on incoming messages was no longer being stored. This can lead to failing endpoint matching.