Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete history_record when endpoint is unmatched <1.9.x> [7602] #1011

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

IkerLuengo
Copy link
Contributor

This is a port of #1006 from 1.8.x

Only a partial port is done, as the main issue was already corrected during a refactoring

  • Ensure persistence_guid_count_ is deleted when it reaches to zero to free memory
  • Change the condition to delete the records from count == 0 to count <= 0 for robustness

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@IkerLuengo IkerLuengo force-pushed the bug/history_record/1.9.x branch from 0c4b8ce to 97fc09a Compare February 13, 2020 10:39
MiguelCompany
MiguelCompany previously approved these changes Feb 13, 2020
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

This is a port of #1006 from 1.8.x

Only a partial port is done, as the main issue was already corrected during a refactoring

 * Ensure persistence_guid_count_ is deleted when it reaches to zero to free memory
 * Change the condition to delete the records from count == 0 to count <= 0 for robustness
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MiguelCompany MiguelCompany merged commit 4691466 into 1.9.x Feb 14, 2020
@MiguelCompany MiguelCompany deleted the bug/history_record/1.9.x branch February 14, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants