Avoid problems with template method inlining. [7601] #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build status:
|
IkerLuengo
added a commit
that referenced
this pull request
Mar 4, 2020
This is a port of #1009 from 1.9.x
MiguelCompany
added a commit
that referenced
this pull request
Mar 5, 2020
* Reduce builtin endpoints memory consumption This is a port of #918 from 1.9.x * Refs #6971. Reducing default builtin history size. * Refs #6971. Default memory policy to preallocated with realloc. * Refs #6971. EDP listeners: remove change from history before releasing lock. * Refs #6971. Reducing EDP readers history. * Refs #6971. WLP not creating secure endpoint when not necessary. * Refs #6971. Improving WLP history. * Refs #6971. Correctly setting DATA(p) serialized size. * Refs #6971. Taking sentinel into account. * Refs #6971. Fixed comparison on addParameterSentinel. * Refs #6971. Fixed WLP destructor. * Refs #6971. Uncrustify EDPSimple and children. * Refs #6971. Joining common code serializing a WriterProxyData. * Refs #6971. Templating for both proxy datas. * Refs #6971. Use templated code for ReaderProxyData. * Refs #6971. Adding basic get_serialized_size() methods. * Refs #6971. Parameter_t::addToCDRMessage made const. * Refs #6971. Added method cdr_serialized_size() to Parameter_t * Refs #6971. Updating ParticipantProxyData * Refs #6971. ReaderProxyData calculating serialization size. * Refs #6971. WriterProxyData calculating serialization size. * Refs #6971. Fixing mocks. * Refs #6971. Fixing warnings. * Refs #7035. Adressing review comments. * Refs #7035. Fixing EDP listeners. * Avoid problems with template method inlining. This is a port of #1009 from 1.9.x * Apply review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1007 by making the template method
EDPSimple::serialize_proxy_dataprivate and adding two protected proxy methods for the two possible instantiations of the template.NOTE: CI jobs have been updated to build on release mode