PublisherHistory: stateless writer never removes samples #34
Comments
liamstask
added a commit
to 3drobotics/Fast-RTPS
that referenced
this issue
Apr 29, 2016
`PublisherHistory::add_pub_change()` calls `clean_history()` and considers history full if it returns false. Actually remove items from history, and return whether we actually removed anything. for eProsima#34
Closed
|
It seems this issue has been solved on version 1.2.0. Cheers! |
12 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The fix for #33 is not correct in the case of a
StatelessWriter. If the publisher is configured with KEEP_LAST_HISTORY_QOS and BEST_EFFORT reliability,StatelessWriter::clean_history()always returns false now, which means that when it's called inPublisherHistory::add_pub_change(), it triggers the path that logsAttempting to add Data to Full WriterCache:.Might be enough to return
truefromStatelessWriter::clean_history()instead.The text was updated successfully, but these errors were encountered: