-
Notifications
You must be signed in to change notification settings - Fork 791
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Datasharing delivery refactor (#1900)
This is a port of #1817 from <main> to <2.2.x> * Refs 10731. DataSharingListener provides access to the pool of a matched writer Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. The writer prioritizes intraprocess over datasharing deliveries Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. The reader prioritizes intraprocess over datasharing deliveries Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Payloads not in the history of writer are considered reusable Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Move override check on the reader to ReadTakeCommand Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Remove override check on best effort Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Check deserialization errors on reader Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Avoid lock on writer when getting payload Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Test deserialization errors Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Adapt DataSharing tests to new implementation Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Remove reusability notifications to writer Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Improve check of data validity on reader Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Modify test to new behavior Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. fixup remove override check on RTPS Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. fix mocks Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. uncrustify Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Suggested changes Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Keep datasharing compatibility on the writer info Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. No error when requested loan size is zero This corrects the regression on DataReaderTests.resource_limits Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Apply suggestions Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Atomic sequence number on datasharing node - Make the sequence number atomic, as it signals the validity or invalidation of the payload - Clear the sequence number first when invalidating, set it last when publishing - Reset the pointer fields on the CacheChange when the pool returns no valid data to the listener. Since the listener provides a stack-allocated CacheChange for the pool to fill, if the return is garbage, the destructor of the CacheChange will do unexpected things Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Protect the notification with the mutex Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Catch deserialization exceptions Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Make sure linters do not complain of void returns Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Uncrustify Signed-off-by: Iker Luengo <ikerluengo@eprosima.com> * Refs 10731. Remove unused argument Signed-off-by: Iker Luengo <ikerluengo@eprosima.com>
- Loading branch information
1 parent
079a48d
commit 5f93fec
Showing
32 changed files
with
573 additions
and
669 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.