Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed various typos and unified some formats in documentation #996

Merged
merged 6 commits into from
Dec 23, 2024

Conversation

juanjo4936
Copy link
Contributor

@juanjo4936 juanjo4936 commented Dec 20, 2024

Description

Fixed some typos found while reading the documentation, fixed some links to c-InstanceHandle_Unknown and unified the format for the references to the different QOS_DEFAULT options.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>
@juanjo4936 juanjo4936 added this to the v3.2.0 milestone Dec 20, 2024
@juanjo4936 juanjo4936 self-assigned this Dec 20, 2024
juanjo4936 and others added 3 commits December 20, 2024 11:57
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
@juanjo4936 juanjo4936 requested review from richiprosima and removed request for richiprosima December 23, 2024 07:40
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
@juanjo4936 juanjo4936 requested review from richiprosima and removed request for richiprosima December 23, 2024 09:53
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima juanlofer-eprosima merged commit 0a46fe1 into master Dec 23, 2024
4 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the fix/juanjo branch December 23, 2024 10:18
@juanlofer-eprosima
Copy link
Contributor

juanlofer-eprosima commented Dec 23, 2024

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

Copy link

mergify bot commented Dec 23, 2024

backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 23, 2024
* Fix links in docu

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Unified the QOS_DEFAULT format in text

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fixed a typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Modified length of a line

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 0a46fe1)
mergify bot pushed a commit that referenced this pull request Dec 23, 2024
* Fix links in docu

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Unified the QOS_DEFAULT format in text

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fixed a typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Modified length of a line

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 0a46fe1)
mergify bot pushed a commit that referenced this pull request Dec 23, 2024
* Fix links in docu

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Unified the QOS_DEFAULT format in text

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fixed a typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Modified length of a line

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 0a46fe1)
@juanlofer-eprosima juanlofer-eprosima removed the request for review from richiprosima December 23, 2024 10:19
mergify bot pushed a commit that referenced this pull request Dec 23, 2024
* Fix links in docu

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Unified the QOS_DEFAULT format in text

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fixed a typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Modified length of a line

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 0a46fe1)

# Conflicts:
#	docs/fastdds/dds_layer/publisher/dataWriter/createDataWriter.rst
#	docs/fastdds/dds_layer/subscriber/dataReader/createDataReader.rst
mergify bot pushed a commit that referenced this pull request Dec 23, 2024
* Fix links in docu

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Unified the QOS_DEFAULT format in text

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fixed a typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Modified length of a line

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 0a46fe1)

# Conflicts:
#	docs/fastdds/dds_layer/publisher/dataWriter/createDataWriter.rst
#	docs/fastdds/dds_layer/subscriber/dataReader/createDataReader.rst
juanlofer-eprosima pushed a commit that referenced this pull request Dec 23, 2024
#996) (#1001)

* Fixed various typos and unified some formats in documentation (#996)

* Fix links in docu

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Unified the QOS_DEFAULT format in text

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fixed a typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Modified length of a line

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 0a46fe1)

# Conflicts:
#	docs/fastdds/dds_layer/publisher/dataWriter/createDataWriter.rst
#	docs/fastdds/dds_layer/subscriber/dataReader/createDataReader.rst

* Solved the conflicts from backport

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
Co-authored-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
juanlofer-eprosima pushed a commit that referenced this pull request Dec 23, 2024
…999)

* Fix links in docu

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Unified the QOS_DEFAULT format in text

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fixed a typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Modified length of a line

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 0a46fe1)

Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
juanlofer-eprosima pushed a commit that referenced this pull request Dec 23, 2024
#996) (#1000)

* Fixed various typos and unified some formats in documentation (#996)

* Fix links in docu

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Unified the QOS_DEFAULT format in text

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fixed a typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Modified length of a line

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 0a46fe1)

# Conflicts:
#	docs/fastdds/dds_layer/publisher/dataWriter/createDataWriter.rst
#	docs/fastdds/dds_layer/subscriber/dataReader/createDataReader.rst

* Solved the conflicts from the backport

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
Co-authored-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
juanlofer-eprosima pushed a commit that referenced this pull request Dec 23, 2024
…998)

* Fix links in docu

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Unified the QOS_DEFAULT format in text

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fixed a typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Modified length of a line

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 0a46fe1)

Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
juanlofer-eprosima pushed a commit that referenced this pull request Dec 23, 2024
…997)

* Fix links in docu

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Unified the QOS_DEFAULT format in text

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fix Typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Fixed a typo

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

* Modified length of a line

Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>

---------

Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
(cherry picked from commit 0a46fe1)

Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants