-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed various typos and unified some formats in documentation #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com>
juanjo4936
force-pushed
the
fix/juanjo
branch
from
December 20, 2024 11:23
dab5a4d
to
5d5dd2c
Compare
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
juanjo4936
requested review from
richiprosima
and removed request for
richiprosima
December 23, 2024 07:40
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
juanjo4936
requested review from
richiprosima
and removed request for
richiprosima
December 23, 2024 09:53
juanlofer-eprosima
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
* Fix links in docu Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Unified the QOS_DEFAULT format in text Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fixed a typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Modified length of a line Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 0a46fe1)
7 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
* Fix links in docu Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Unified the QOS_DEFAULT format in text Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fixed a typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Modified length of a line Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 0a46fe1)
mergify bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
* Fix links in docu Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Unified the QOS_DEFAULT format in text Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fixed a typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Modified length of a line Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 0a46fe1)
This was referenced Dec 23, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
* Fix links in docu Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Unified the QOS_DEFAULT format in text Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fixed a typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Modified length of a line Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 0a46fe1) # Conflicts: # docs/fastdds/dds_layer/publisher/dataWriter/createDataWriter.rst # docs/fastdds/dds_layer/subscriber/dataReader/createDataReader.rst
7 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
* Fix links in docu Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Unified the QOS_DEFAULT format in text Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fixed a typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Modified length of a line Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 0a46fe1) # Conflicts: # docs/fastdds/dds_layer/publisher/dataWriter/createDataWriter.rst # docs/fastdds/dds_layer/subscriber/dataReader/createDataReader.rst
7 tasks
juanlofer-eprosima
pushed a commit
that referenced
this pull request
Dec 23, 2024
#996) (#1001) * Fixed various typos and unified some formats in documentation (#996) * Fix links in docu Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Unified the QOS_DEFAULT format in text Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fixed a typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Modified length of a line Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 0a46fe1) # Conflicts: # docs/fastdds/dds_layer/publisher/dataWriter/createDataWriter.rst # docs/fastdds/dds_layer/subscriber/dataReader/createDataReader.rst * Solved the conflicts from backport Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com> Co-authored-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
juanlofer-eprosima
pushed a commit
that referenced
this pull request
Dec 23, 2024
…999) * Fix links in docu Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Unified the QOS_DEFAULT format in text Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fixed a typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Modified length of a line Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 0a46fe1) Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
juanlofer-eprosima
pushed a commit
that referenced
this pull request
Dec 23, 2024
#996) (#1000) * Fixed various typos and unified some formats in documentation (#996) * Fix links in docu Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Unified the QOS_DEFAULT format in text Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fixed a typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Modified length of a line Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 0a46fe1) # Conflicts: # docs/fastdds/dds_layer/publisher/dataWriter/createDataWriter.rst # docs/fastdds/dds_layer/subscriber/dataReader/createDataReader.rst * Solved the conflicts from the backport Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com> Co-authored-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
juanlofer-eprosima
pushed a commit
that referenced
this pull request
Dec 23, 2024
…998) * Fix links in docu Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Unified the QOS_DEFAULT format in text Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fixed a typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Modified length of a line Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 0a46fe1) Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
juanlofer-eprosima
pushed a commit
that referenced
this pull request
Dec 23, 2024
…997) * Fix links in docu Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Unified the QOS_DEFAULT format in text Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fix Typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Fixed a typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Modified length of a line Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarciaesteban@gmail.com> Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> (cherry picked from commit 0a46fe1) Co-authored-by: juanjo4936 <69901369+juanjo4936@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed some typos found while reading the documentation, fixed some links to c-InstanceHandle_Unknown and unified the format for the references to the different QOS_DEFAULT options.
@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x
Contributor Checklist
Reviewer Checklist